davsclaus commented on code in PR #30221:
URL: https://github.com/apache/camel/pull/30221#discussion_r4588424586
##########
dsl/camel-kamelet-main/src/main/java/org/apache/camel/main/util/VersionHelper.java:
##########
@@ -124,6 +127,21 @@ public static String extractKameletsVersion() {
}
}
+ // Executable JARs do not expose their nested dependencies in
java.class.path.
Review Comment:
[Nit] The `lib/` distribution has the same gap: `camel.sh` runs `java -jar
camel-launcher-*.jar`, and the JARs in the manifest's `Class-Path` are not in
`java.class.path`. Maybe: `// a launcher JAR (nested JARs, or a manifest
Class-Path) does not expose its dependencies in java.class.path`.
##########
docs/user-manual/modules/ROOT/pages/camel-4x-upgrade-guide-4_24.adoc:
##########
@@ -8689,6 +8689,12 @@ dead letter channel or a handled `onException`, so that
the item is marked consu
`delay`, or set `backoffIdleThreshold` and `backoffMultiplier`: a poll counts
only the items that it marked consumed,
so a poll whose items all failed is an idle poll, after which a `greedy`
consumer does not poll again at once.
+=== camel-jbang - Kamelets version detection in executable launchers
+
+When exporting without `--kamelets-version`, Camel CLI now detects the
Kamelets catalog bundled inside an executable
Review Comment:
In the Apache build, the bundled `camel-kamelets` and the fallback
`camel-kamelets-catalog-version` are both 4.23.0, bumped together by the
dependabot `kamelet` group, so exports do not change. The detection also feeds
`camel run`, `init`, `catalog kamelet`, `catalog doc`, `dependency list`, MCP
and the Kubernetes plugin, not only export. Can we drop this entry, or reword
it to cover every command that uses the default Kamelets version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]