oscerd commented on PR #30191: URL: https://github.com/apache/camel/pull/30191#issuecomment-6924033343
@davsclaus, thanks: your four points, in 9b740b0. 1. **Credentials of `simple.properties` in local mode:** the tests now fail fast with `simple.properties gives credentials: add -Dgoogle.instance.type=remote to run the tests against the BigQuery of that project`. The check uses the condition that enabled the ITs before this PR (`service.key` + `service.account`, or `service.credentialsFileLocation`). Checked by adding `service.credentialsFileLocation` to `simple.properties`: 7 errors with that message, and `InsertIdIT` stays skipped. 2. **Project ids:** `GoogleBigQueryLocalContainerInfraService.projectId()` now returns `System.getProperty(GoogleBigQueryProperties.PROJECT_ID, DEFAULT_PROJECT_ID)`, as the storage service does. The tests keep the project and the dataset of `simple.properties` in both modes, since Floci GCP accepts any project id, and the `BigQueryITSupport` javadoc now says so. 3. **Subclass:** removed. The local factory is `new GoogleBigQueryConnectionFactory(client)`, built once and shared by both components, which also covers gnodet-bot's thread. 4. **Merge order:** noted. Whichever of #29828 / #30191 merges second, I will rebase it and regenerate the metadata with the full reactor. The same change also takes Croway's two findings: the engine image is pulled in `initialize()`, so without Docker the 9 tests are skipped again, and a container removal already in progress is ignored. The full reactor build is green. _Claude Code on behalf of Andrea Cosentino_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
