Croway opened a new pull request, #30229:
URL: https://github.com/apache/camel/pull/30229

   JIRA: [CAMEL-27060](https://issues.apache.org/jira/browse/CAMEL-27060)
   
   - The file, ftp, ftps, sftp, mina-sftp, azure-files and smb consumers use 
`idempotentRepository` and `idempotentKey` only with `idempotent=true` 
(`noop=true` turns it on). Set alone, they do nothing: files already consumed 
are not skipped, and nothing was logged.
   - Creating the consumer now logs a WARN that names the unused options and 
`idempotent=true` (`GenericFileEndpoint.warnIfIdempotentOptionsUnused`, called 
from `FileEndpoint`, `RemoteFileEndpoint` and `SmbEndpoint`). Behaviour does 
not change.
   - No WARN with the idempotent read locks (`readLock=idempotent`, 
`idempotent-changed`, `idempotent-rename`), which use these options without 
`idempotent=true`, with a custom `processStrategy` or 
`exclusiveReadLockStrategy`, or with an explicit `idempotent=false`.
   - The descriptions of `idempotent`, `idempotentKey` and 
`idempotentRepository` say when the options apply (component JSONs, catalog and 
Endpoint DSL regenerated), and the file component page has a note.
   
   Tests: `FileConsumerIdempotentOptionsWithoutIdempotentTest` (camel-core), 
`RemoteFileEndpointIdempotentOptionsTest` (camel-ftp), 
`SmbEndpointIdempotentOptionsTest` (camel-smb). The WARN cases fail before 
(3/10, 9/26, 1/5) and pass after; the controls pass both ways.
   
   No upgrade guide entry: only a new WARN and docs.
   
   _Claude Code on behalf of Federico Mariani_
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to