davsclaus opened a new pull request, #3147:
URL: https://github.com/apache/camel-kamelets/pull/3147
_Claude Code on behalf of Claus Ibsen_
A batch of Kamelets rewritten to the documentation standard proposed in
#3140, `docs/modules/ROOT/pages/documenting.adoc`, like #3141–#3146.
This batch has 14 Kamelets and their partial pages:
- `minio-source`, `minio-sink`, `ceph-source`, `ceph-sink` and
`ceph-event-based-source`;
- the five GitHub sources;
- the three Kubernetes sources;
- `webhook-source`.
## How they were checked
| Kamelets | Checked |
|---|---|
| MinIO and Ceph | Run against MinIO in Docker. MinIO also stood in for
Ceph's S3 gateway. |
| `ceph-event-based-source` | Run against Kafka and MinIO, on 4.23.0 and
4.24.0-SNAPSHOT. |
| Kubernetes sources | Run against a local stand-in of the Kubernetes watch
API. |
| `webhook-source` | Run, and sent requests with curl. |
| GitHub sources | Checked against the template, the catalog and the
component source. Without a token they stop at the 401. |
## Facts that were missing or wrong before
- **`minio-source`:**
- the body is bytes, not JSON, which its partial page claimed;
- it deletes each file after reading by default;
- it does not read files in folders.
- **`ceph-source`:** reads folders, and also deletes after reading by
default.
- **How the sinks name the object:** the two sinks look at the inputs in
opposite orders.
- `minio-sink`: `keyName`, then the `file` header, then `ce-file`, then a
generated name;
- `ceph-sink`: `file`, then `ce-file`, then `keyName`.
- **Ceph addresses:** there is no `forcePathStyle`, so the bucket goes into
the host name. A `localhost` address fails where `127.0.0.1` works. This is in
`Good to know`.
- **The GitHub sources:**
- send only new pull requests, comments and tags;
- the body of the commit and event sources is a quoted JSON string such as
`"Fix the build"` or `"PUSH"`, and the details are in headers.
- **The Kubernetes sources:**
- send the pod, node or namespace as JSON text;
- existing ones come first, as `ADDED`;
- their partial pages listed authentication methods and a `namespace`
option the Kamelets do not have.
- **`webhook-source`:**
- the body is a stream;
- it accepts every HTTP method on the exact path;
- `Good to know` says that anyone who can reach it can send messages;
- the filter example in its partial page was not valid YAML DSL.
## Left out, and found on the way
- **`dropbox-source` and `dropbox-sink` are not in this PR,** because they
do not start (4.23 and 4.24): `DropboxException: option <expireIn> is not
present or not valid!`. The component now also requires `refreshToken`,
`apiKey` and `apiSecret`, which the Kamelets do not expose. They will be
described with their fix.
- **`kubernetes-pods-source` ignores `resourceName`.** The component applies
a pod name only together with a namespace, and the Kamelet has no namespace
option.
- **The GitHub sources poll every 500 ms**, the component default, because
the template sets no delay. That is over 7,200 API calls an hour, more than the
5,000 a token may make.
- **`ceph-event-based-source` with `getObject=true` fails on every event on
Camel 4.24.** Its `unmarshalType` is a Jackson 2 `JsonNode`, as in the other
batches.
- **`webhook-source`:** a form post becomes a Map, and in a flow that only
logs it, the caller gets HTTP 500.
## Notes for review
- No template, type, default or required list was changed. The one new
`enum`, on `dropbox-sink` `uploadMode`, is not in this PR. The `dataTypes`
blocks are `headers` only, with no `default`.
- `KameletsCatalogTest.testSupportedHeaders`: the catalog now returns the
headers these Kamelets declare instead of those of their components. The
changed counts:
- `github-commit-source` 7 → 4
- `github-event-source` 7 → 1
- `github-pullrequest-comment-source` 7 → 1
- `github-pullrequest-source` 7 → 2
- `minio-source` 15 → 5
- `minio-sink` 23 → 2
- `webhook-source` 0 → 3
- This PR is based on `main`; if #3140 merges first, I will rebase it and
regenerate the index.
`./mvnw clean install` from the root passes.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]