gnodet commented on code in PR #30242:
URL: https://github.com/apache/camel/pull/30242#discussion_r4591890160


##########
docs/user-manual/modules/ROOT/pages/camel-4x-upgrade-guide-4_22.adoc:
##########
@@ -906,6 +906,21 @@ catalog version for Camel core dependencies in the 
generated project. For exampl
 uses Camel 4.8.0 instead of the running CLI's version when that catalog is 
available. Set `--camel-version` explicitly
 to retain a different core dependency version.
 
+=== camel-main - the server and vault options flagged secret are sensitive keys
+
+The options `camel.server.jwtKeystorePassword`, 
`camel.management.jwtKeystorePassword`,
+`camel.vault.azure.eventhubConnectionString`, `camel.vault.azure.tenantId`, 
`camel.vault.gcp.serviceAccountKey`,
+`camel.vault.ibm.eventStreamUsername` and 
`camel.vault.ibm.eventStreamPassword` are flagged secret, and are now also
+sensitive keys, like the other secret options. The Camel Main 
auto-configuration summary shows their value as `xxxxxx`.
+These options are matched by their whole key. Component and endpoint options 
with the same name, such as `tenantId` or

Review Comment:
   🔤 **Nit (optional):** Passive voice — `are matched` and (on the following 
line) `are not affected`. Consider active rewrites:
   
   > The options' whole key must match. Component and endpoint options with the 
same name, such as `tenantId` or `serviceAccountKey`, are unaffected.
   
   (The same sentences appear verbatim in the 4.18 counterpart — apply there 
too if you take the suggestion.)



##########
docs/user-manual/modules/ROOT/pages/camel-4x-upgrade-guide-4_22.adoc:
##########
@@ -906,6 +906,21 @@ catalog version for Camel core dependencies in the 
generated project. For exampl
 uses Camel 4.8.0 instead of the running CLI's version when that catalog is 
available. Set `--camel-version` explicitly
 to retain a different core dependency version.
 
+=== camel-main - the server and vault options flagged secret are sensitive keys
+
+The options `camel.server.jwtKeystorePassword`, 
`camel.management.jwtKeystorePassword`,
+`camel.vault.azure.eventhubConnectionString`, `camel.vault.azure.tenantId`, 
`camel.vault.gcp.serviceAccountKey`,
+`camel.vault.ibm.eventStreamUsername` and 
`camel.vault.ibm.eventStreamPassword` are flagged secret, and are now also
+sensitive keys, like the other secret options. The Camel Main 
auto-configuration summary shows their value as `xxxxxx`.
+These options are matched by their whole key. Component and endpoint options 
with the same name, such as `tenantId` or
+`serviceAccountKey`, are not affected.
+
+The `camel.security.secretPolicy` check now also reports these options when 
they are configured as plain text,
+including a value set through an environment variable: a warning by default, 
and the startup fails with
+`camel.main.profile=prod`. Configure them with a property placeholder or a 
vault reference instead.
+A file location in `camel.vault.gcp.serviceAccountKey`, such as 
`file:/etc/gcp/sa.json`, is also reported. It can go
+behind a property placeholder too.

Review Comment:
   🔤 **Nit (optional):** Passive voice — `is also reported`. Suggested active 
rewrite:
   
   > Camel also reports a file location in `camel.vault.gcp.serviceAccountKey`, 
such as `file:/etc/gcp/sa.json`. It can go behind a property placeholder too.
   
   (The sentence wraps across lines 921–922 — apply the split manually.)



##########
docs/user-manual/modules/ROOT/pages/camel-4x-upgrade-guide-4_22.adoc:
##########
@@ -906,6 +906,21 @@ catalog version for Camel core dependencies in the 
generated project. For exampl
 uses Camel 4.8.0 instead of the running CLI's version when that catalog is 
available. Set `--camel-version` explicitly
 to retain a different core dependency version.
 
+=== camel-main - the server and vault options flagged secret are sensitive keys
+
+The options `camel.server.jwtKeystorePassword`, 
`camel.management.jwtKeystorePassword`,
+`camel.vault.azure.eventhubConnectionString`, `camel.vault.azure.tenantId`, 
`camel.vault.gcp.serviceAccountKey`,
+`camel.vault.ibm.eventStreamUsername` and 
`camel.vault.ibm.eventStreamPassword` are flagged secret, and are now also
+sensitive keys, like the other secret options. The Camel Main 
auto-configuration summary shows their value as `xxxxxx`.
+These options are matched by their whole key. Component and endpoint options 
with the same name, such as `tenantId` or
+`serviceAccountKey`, are not affected.
+
+The `camel.security.secretPolicy` check now also reports these options when 
they are configured as plain text,
+including a value set through an environment variable: a warning by default, 
and the startup fails with
+`camel.main.profile=prod`. Configure them with a property placeholder or a 
vault reference instead.

Review Comment:
   🔤 **Nit (optional):** Sentence at lines 918–920 chains three clauses (~33 
words). Consider splitting:
   
   > The `camel.security.secretPolicy` check now also reports these options 
when they are configured as plain text, including values set through 
environment variables. By default this logs a warning; with 
`camel.main.profile=prod` the startup fails. Configure them with a property 
placeholder or a vault reference instead.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to