jamesnetherton commented on PR #3136:
URL: https://github.com/apache/camel-kamelets/pull/3136#issuecomment-6942276797

   Thanks @davsclaus, this matches what we expected. The PR is a draft 
placeholder until the catalog moves to Camel 4.24.0, so the CI failures here 
are expected until then.
   
   I checked your findings locally, running this PR's Kamelets on a current 
Camel 4.24.0-SNAPSHOT build:
   
   - **Coverage:** the 90 Kamelets on `main` that use Jackson 2 are exactly the 
90 Kamelets this PR changes. After the PR, no Jackson 2 references are left in 
the Kamelets.
   - **All the itests that fail in CI here pass:** `CommonIT` (39/39, including 
the field actions), `JiraIT` (3/3, the `JodaModule` case), `AvroIT` and 
`ProtobufIT` (4/4).
   - **`data-type-action` with `avro-binary` / `protobuf-binary` after 
`resolve-pojo-schema-action`:** this passes with this PR. With the unchanged 
`main` Kamelets on the same Camel version, the Avro and Protobuf tests fail. 
The data-type tests fail before reaching `data-type-action`, at 
`json-deserialize-action`: Jackson 3 can't create a 
`com.fasterxml.jackson.databind.JsonNode`.
   
   So the current catalog doesn't work on Camel 4.24, and this PR fixes that. 
CI here should go green once the catalog moves to Camel 4.24.0.
   
   Thanks for taking care of the docs PR rebases.
   
   _Claude Code on behalf of James Netherton_
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to