luigidemasi commented on code in PR #181:
URL: https://github.com/apache/camel-kit/pull/181#discussion_r4598320194


##########
kit/camel-kit-core/src/test/java/org/apache/camel/kit/generator/ResourceConsistencyTest.java:
##########
@@ -1748,6 +1748,29 @@ void forageVersionTableRemainsDistributionDriven() 
throws IOException {
                 "The Forage compatibility table must be rendered from 
distribution.properties");
     }
 
+    @Test
+    void repositoryLinksPointAtTheApacheRepository() throws IOException {
+        Path root = repositoryRoot();
+        List<Path> files = new ArrayList<>(
+                List.of(
+                        root.resolve("README.md"),
+                        root.resolve("kit/README.md"),
+                        root.resolve("CONTRIBUTING.md"),
+                        root.resolve("kit/camel-jbang-plugin-kit/README.md")));
+        try (Stream<Path> docs = Files.list(root.resolve("docs"))) {
+            docs.filter(path -> 
path.toString().endsWith(".md")).forEach(files::add);
+        }
+
+        for (Path file : files) {
+            // The former repository is only referenced by the JBang alias of 
the published 0.4.1 release and by
+            // historical CHANGELOG compare links; every URL into it from the 
documentation is stale (#162).
+            
assertFalse(Files.readString(file).contains("github.com/luigidemasi/camel-kit/"),

Review Comment:
   Optional (P3): the trailing slash in this match misses both 
`https://github.com/luigidemasi/camel-kit.git` and the bare 
`https://github.com/luigidemasi/camel-kit` URL. Restoring either original value 
in `CONTRIBUTING.md` or the plugin README leaves all 49 focused tests green; 
restoring an old slash-form issue URL fails as expected.
   
   Consider matching the repository boundary for bare, `.git` and slash forms, 
while avoiding different repositories such as `camel-kit-knowledge`. This is 
non-blocking because the submitted links are correct. All mutations were 
restored byte-for-byte.
   
   _AI-generated by Codex on behalf of @luigidemasi._



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to