davsclaus opened a new pull request, #3185:
URL: https://github.com/apache/camel-kamelets/pull/3185

   Part of #3144: `kafka-sink`, `kafka-batch-source` and 
`ceph-event-based-source` require an explicit `saslAuthType`, as `kafka-source` 
has done since #3069 (Fix #2970).
   
   Until now these three defaulted `saslAuthType` to `NONE`. A Kamelet given 
only `topic` and `bootstrapServers` therefore connected to Kafka in plaintext, 
with no login, and nothing in its name said so. #2970 fixed this for 
`kafka-source`. This PR does the same for the other Kafka Kamelets with a 
security selector, so all the Kafka Kamelets behave the same.
   
   ### What changes
   
   - **The option:** `saslAuthType` loses its `default: NONE` and is listed 
under `required`.
   - **`NONE` stays available,** and works exactly as before; it just has to be 
asked for: `saslAuthType: NONE`.
   - **Descriptions:** the option description and the "Good to know" paragraph 
of each Kamelet say that it has no default and must be set, in the words 
`kafka-source` uses. The `kafka-sink` option description had not been rewritten 
yet, and now matches `kafka-source`.
   - **Doc pages:** the `kafka-sink` and `kafka-batch-source` partial pages no 
longer call `NONE` the default. The `kafka-sink` example sets `saslAuthType: 
NONE`.
   - **Integration tests:** the `kafka-sink-route` and `kafka-router-route` 
itest routes set `saslAuthType: NONE`, as #3069 did for `kafka-source`.
   - **Pipe templates:** they already set it.
   
   ### Breaking change, for the upgrade notes
   
   A route or Pipe that uses `kafka-sink`, `kafka-batch-source` or 
`ceph-event-based-source` without `saslAuthType` now fails at startup instead 
of connecting without security:
   
   ```
   Route template kafka-sink the following mandatory parameters must be 
provided: saslAuthType
   ```
   
   To keep the old behaviour, add `saslAuthType: NONE`.
   
   ### Verification
   
   Tested with Camel JBang against Kafka (`apache/kafka`) in Docker:
   
   | Case | Result |
   |---|---|
   | Each of the three Kamelets without `saslAuthType` | The startup error 
above |
   | `kafka-sink` and `kafka-batch-source` with `saslAuthType: NONE` | 3 
records written; read back as one batch of 3 |
   
   `./mvnw clean install` passed twice, the first time with `-DskipTests`.
   
   _Claude Code on behalf of Claus Ibsen_
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to