This is an automated email from the ASF dual-hosted git repository. luigidemasi pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/camel-kit.git
commit 28b1ef36c72d6d1d37f92ecfa1156d303347ec55 Author: Luigi De Masi <[email protected]> AuthorDate: Tue Nov 17 17:42:09 2026 +0100 Scope validation runtime handoff to Stage 3 Preserve schema validation and existing-project baseline test reruns while reporting runtime verification from the execution report. Add a dedicated contract test that rejects inline route-start commands even when the reporting-only instructions remain present. Addresses both findings in PR #176. Co-authored-by: OpenAI Codex <[email protected]> --- .../camel-validate/guides/endpoint-validation.md | 8 +++--- .../kit/generator/ResourceConsistencyTest.java | 33 ++++++++++++++++------ 2 files changed, 29 insertions(+), 12 deletions(-) diff --git a/kit/camel-kit-core/src/main/resources/skills/camel-validate/guides/endpoint-validation.md b/kit/camel-kit-core/src/main/resources/skills/camel-validate/guides/endpoint-validation.md index 905aa462..5a2552a5 100644 --- a/kit/camel-kit-core/src/main/resources/skills/camel-validate/guides/endpoint-validation.md +++ b/kit/camel-kit-core/src/main/resources/skills/camel-validate/guides/endpoint-validation.md @@ -87,9 +87,9 @@ Validating component existence... ## Stage 3: Runtime Handoff -`/camel-validate` is a static gate: it never starts the routes, runs a build or downloads dependencies, and the Camel -CLI has no dry-run option for `camel run` (no `--check` flag exists). Do not run anything in this stage. Every concern -a runtime start would surface is covered elsewhere — record where: +Stage 3 only reports existing runtime-verification evidence. Do not start routes, run a build, or download dependencies +in this stage. This restriction does not skip schema validation or the existing-project baseline test rerun. +The Camel CLI has no dry-run option for `camel run` (no `--check` flag exists). Record where each runtime concern is checked: | Runtime concern | Covered by | |---|---| @@ -104,7 +104,7 @@ Show the handoff, quoting the `Verification:` value from `execution-report.md` w ``` == RUNTIME VALIDATION == -Not run by /camel-validate (static gate; `camel run` has no check mode). +Not run in Stage 3 (reporting-only handoff; `camel run` has no check mode). Runtime verification: {PASS | PARTIAL | FAIL | NOT_RUN} per execution-report.md ``` diff --git a/kit/camel-kit-core/src/test/java/org/apache/camel/kit/generator/ResourceConsistencyTest.java b/kit/camel-kit-core/src/test/java/org/apache/camel/kit/generator/ResourceConsistencyTest.java index 5b116ca6..e8320edc 100644 --- a/kit/camel-kit-core/src/test/java/org/apache/camel/kit/generator/ResourceConsistencyTest.java +++ b/kit/camel-kit-core/src/test/java/org/apache/camel/kit/generator/ResourceConsistencyTest.java @@ -1667,7 +1667,6 @@ class ResourceConsistencyTest { Path root = repositoryRoot().resolve("kit/camel-kit-core/src/main/resources/skills"); String validate = Files.readString(root.resolve("camel-validate/SKILL.md")); String schema = Files.readString(root.resolve("camel-validate/guides/schema-validation.md")); - String endpoint = Files.readString(root.resolve("camel-validate/guides/endpoint-validation.md")); String replan = Files.readString(root.resolve("camel-execute/guides/re-plan-loop.md")); assertTrue(validate.contains("Main: `ROUTE_FILES` is every `{MODULE_PREFIX}*.camel.yaml`")); @@ -1675,18 +1674,36 @@ class ResourceConsistencyTest { "`{MODULE_PREFIX}src/main/resources/camel/*.camel.yaml`")); assertTrue(validate.contains("`{MODULE_PREFIX}` is empty at the project root")); assertTrue(schema.contains("-Dcamel.validator.files={ROUTE_FILE}")); - assertFalse(endpoint.contains("camel run --check"), "camel run has no --check option (#145)"); - assertFalse(endpoint.contains("```bash"), - "/camel-validate is static: the endpoint guide runs no shell command"); - assertTrue(endpoint.contains("## Stage 3: Runtime Handoff")); - assertTrue(endpoint.contains("`quality-checks.md` §7.2 Property Completeness")); - assertTrue(endpoint.contains("`quality-checks.md` §7.3 Bean Definitions")); - assertTrue(endpoint.contains("`Verification:` line of `execution-report.md`")); assertTrue(replan.contains("Never execute tasks copied from the stale original plan")); assertTrue(replan.contains("plan analyze <plan-path>")); assertTrue(replan.contains("doc unstale <plan-path>")); } + @Test + void endpointRuntimeHandoffKeepsOtherValidationStages() throws IOException { + Path root = repositoryRoot().resolve("kit/camel-kit-core/src/main/resources/skills"); + String endpoint = Files.readString(root.resolve("camel-validate/guides/endpoint-validation.md")); + String validate = Files.readString(root.resolve("camel-validate/SKILL.md")); + + assertFalse(endpoint.contains("camel run --check"), "camel run has no --check option (#145)"); + assertFalse(endpoint.contains("```bash"), + "the endpoint guide runs no shell command"); + assertTrue(endpoint.contains("## Stage 3: Runtime Handoff")); + String handoff = endpoint.substring(endpoint.indexOf("## Stage 3: Runtime Handoff")).replaceAll("\\s+", " "); + assertTrue(handoff.contains("Stage 3 only reports existing runtime-verification evidence.")); + assertTrue(handoff.contains("Do not start routes, run a build, or download dependencies in this stage.")); + assertTrue(handoff.contains("This restriction does not skip schema validation" + + " or the existing-project baseline test rerun.")); + assertFalse(handoff.matches(".*\\bcamel\\s+run\\s+.*"), "Stage 3 must not include a route-start command"); + assertTrue(handoff.contains("`quality-checks.md` §7.2 Property Completeness")); + assertTrue(handoff.contains("`quality-checks.md` §7.3 Bean Definitions")); + assertTrue(handoff.contains("`Verification:` line of `execution-report.md`")); + assertTrue(handoff.contains("Runtime verification: {PASS | PARTIAL | FAIL | NOT_RUN}")); + assertTrue(handoff.contains("Runtime verification: not available")); + assertTrue(validate.contains("### Step 4: Baseline Test Re-Run")); + assertTrue(validate.contains("./mvnw test -B")); + } + @Test void camelTestGuidesUseConcreteMcpValidationContract() throws IOException { Path root = repositoryRoot();
