davsclaus commented on code in PR #30298:
URL: https://github.com/apache/camel/pull/30298#discussion_r4604483041


##########
dsl/camel-yaml-dsl/camel-yaml-dsl-deserializers/src/generated/java/org/apache/camel/dsl/yaml/deserializers/ModelDeserializers.java:
##########
@@ -732,8 +732,8 @@ protected boolean setProperty(ApiKeyDefinition target, 
String propertyKey,
                     @YamlProperty(name = "include", type = "string", 
description = "If you want to marshal a pojo to JSON, and the pojo has some 
fields with null values. And you want to skip these null values, you can set 
this option to NON_NULL.", displayName = "Include"),
                     @YamlProperty(name = "instanceClassName", type = "string", 
description = "Class name to use for marshal and unmarshalling.", displayName = 
"Instance Class Name"),
                     @YamlProperty(name = "jsonView", type = "string", 
description = "When marshalling a POJO to JSON you might want to exclude 
certain fields from the JSON output. With Jackson you can use JSON views to 
accomplish this. This option is to refer to the class which has JsonView 
annotations.", displayName = "Json View"),
-                    @YamlProperty(name = "library", type = 
"enum:ApacheAvro,Jackson", defaultValue = "avroJackson", description = "Which 
Avro library to use.", displayName = "Library"),
-                    @YamlProperty(name = "moduleClassNames", type = "string", 
description = "To use custom Jackson modules 
com.fasterxml.jackson.databind.Module specified as a String with FQN class 
names. Multiple classes can be separated by comma.", displayName = "Module 
Class Names"),
+                    @YamlProperty(name = "library", type = 
"enum:ApacheAvro,Jackson", defaultValue = "Jackson", description = "Which Avro 
library to use.", displayName = "Library"),
+                    @YamlProperty(name = "moduleClassNames", type = "string", 
description = "To use custom Jackson modules specified as a String with FQN 
class names. Multiple classes can be separated by comma.", displayName = 
"Module Class Names"),

Review Comment:
   `moduleClassNames` must keep the description of `camel-4.22.x`. 
`AvroDataFormat.java:86` on this branch still says "To use custom Jackson 
modules com.fasterxml.jackson.databind.Module specified as a String with FQN 
class names", so the regen of the build puts that text back, and the 
"uncommitted changes" check fails. The shorter text comes from main, where the 
description changed after the branch was cut. Only the `library` line above 
should change in this file.
   
   ```suggestion
                       @YamlProperty(name = "moduleClassNames", type = 
"string", description = "To use custom Jackson modules 
com.fasterxml.jackson.databind.Module specified as a String with FQN class 
names. Multiple classes can be separated by comma.", displayName = "Module 
Class Names"),
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to