luigidemasi commented on code in PR #185:
URL: https://github.com/apache/camel-kit/pull/185#discussion_r4607289629


##########
kit/camel-jbang-plugin-kit/pom.xml:
##########
@@ -13,8 +13,8 @@
     <description>JBang plugin for Camel Kit - Design Apache Camel Integrations 
with AI</description>
 
     <properties>
-        <maven.compiler.source>17</maven.compiler.source>
-        <maven.compiler.target>17</maven.compiler.target>
+        <!-- The Aesh-based Camel host requires Java 21; standalone Kit stays 
on Java 17. -->
+        <maven.compiler.release>21</maven.compiler.release>

Review Comment:
   Fixed in 
[2959eabf](https://github.com/apache/camel-kit/commit/2959eabfe8227ab90f72ea91cdea8fabded3fd1d).
 Java 21 is now the shared reactor baseline, including standalone Kit and 
source-built Knowledge; the plugin-only override is removed. Both publishing 
workflows use JDK 21, the build/CLI matrices contain only 21 and 25, and 
artifact upload selects the Java 21 build. The JBang launchers, 
contributor/install/release documentation and project rules are aligned.
   
   Verified at current head `d3e06236`: the full 13-module Java 21 `./mvnw -B 
clean install` and sourcecheck pass. The separate Java 17 branches are gone.
   
   _AI-generated by OpenAI Codex on behalf of @luigidemasi._



##########
docs/modules/ROOT/pages/ship.adoc:
##########
@@ -54,6 +54,17 @@ camel-kit ship --submit RUN_ID --result PATH [--json]
 Context is optional: a bare `camel-kit ship` starts a short discovery 
conversation. Text and documents are added to
 the discovery input before any question, and open points come back as grouped 
unresolved questions.
 
+[[literal-context]]
+=== Literal context and argument files
+
+Text and document occurrences keep their original order, including mixed 
repeated options.
+Standalone `camel-kit ship --text '@note'` passes `@note` literally and never 
expands argument files.
+With the Aesh-based development plugin, the Camel host expands `@file` before 
Kit runs. Write

Review Comment:
   Addressed in 
[2959eabf](https://github.com/apache/camel-kit/commit/2959eabfe8227ab90f72ea91cdea8fabded3fd1d).
 The [Ship 
documentation](https://github.com/apache/camel-kit/blob/d3e062367cb235695ed09304472858e804c44598/docs/modules/ROOT/pages/ship.adoc#L57)
 now explicitly states that an unescaped missing `@file` fails with `Argument 
file not found` and exit 2 before Kit runs. The actual-host subprocess test 
asserts that error, empty stdout and no `.camel-kit` state.
   
   This migration keeps the documented syntax change: plugin callers use 
`@@value` or attached `--text=@value` / `--document=@value`; standalone Ship 
still accepts literal `@` unchanged. The upstream exemption hook would be an 
alternative compatibility policy. Kit cannot bypass expansion that happens 
before the plugin loads, so the escape policy is intentional and covered by the 
hosted tests.
   
   _AI-generated by OpenAI Codex on behalf of @luigidemasi._



##########
distribution.properties:
##########
@@ -10,6 +10,11 @@
 # Each platform has its own default Camel version because release schedules
 # differ. Quarkus typically lags behind the main Camel release.
 
+# CLI host only; generated integration runtime defaults remain independent.
+camel.cli.version=4.24.0-SNAPSHOT

Review Comment:
   The release pin has not been switched: the [Camel 4.24.0 host 
POM](https://repo.maven.apache.org/maven2/org/apache/camel/camel-jbang-core/4.24.0/camel-jbang-core-4.24.0.pom)
 still returns HTTP 404, so the development build retains `4.24.0-SNAPSHOT`.
   
   
[2959eabf](https://github.com/apache/camel-kit/commit/2959eabfe8227ab90f72ea91cdea8fabded3fd1d)
 adds a [release 
guard](https://github.com/apache/camel-kit/blob/d3e062367cb235695ed09304472858e804c44598/tools/release_target.py#L49)
 that rejects snapshots, timestamped snapshots, prereleases, hosts older than 
4.24.0 and a stale POM mirror. The release instructions require a tested 
released host before staging, and the 15 release/distribution tests pass. This 
prevents shipping Kit with the development host, but it does not fulfill the 
actual release-pin switch, so I am leaving this thread unresolved.
   
   _AI-generated by OpenAI Codex on behalf of @luigidemasi._



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to