gnodet-bot commented on code in PR #30305:
URL: https://github.com/apache/camel/pull/30305#discussion_r4610299707


##########
core/camel-core-processor/src/main/java/org/apache/camel/processor/MulticastProcessor.java:
##########
@@ -490,6 +495,20 @@ protected abstract class MulticastTask implements 
Runnable, Rejectable {
             } else {
                 this.completion = new AsyncCompletionService<>(transacted ? 
txScheduler : scheduler, !isStreaming(), lock);
             }

Review Comment:
   🔹 **Minor:** The task is added to `parallelTasks` in the constructor, before 
submission to the pool. If construction succeeds but the subsequent `submit()` 
throws `RejectedExecutionException`, the existing `Rejectable.rejected()` 
callback must call a terminal method (`doFailed`/`doDone`) that invokes 
`markDone()` to remove the task from the set — otherwise it leaks. Worth 
confirming the `rejected()` implementation calls through to `doFailed()`. Not 
blocking — if it doesn't, `doShutdown()` would claim it anyway, but it's worth 
a quick check.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to