allthingssecurity commented on PR #30307: URL: https://github.com/apache/camel/pull/30307#issuecomment-6972898622
On the stop test: agreed. With `schedule()` the thread in `run()` is gone at once, so `stopLeavesNoThreadWaitingForThePolls` (GridFsConsumerTimestampTest.java:344) also passes without the `pollTask.cancel(false)` in `doStop`. The shutdown of `taskExecutor` already ends the polls on its own, so the missing cancel shows only in the task registry: the scheduled task adds itself there from its first run (BackgroundTask.java:111), and only `cancel()` removes it again (`deregister`). I will push a follow-up to the test that checks the `TaskManagerRegistry` size is back to its value before the start once the consumer is stopped, and that no poll runs after the stop. Thanks. _Claude Code on behalf of allthingssecurity_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
