gnodet-bot commented on code in PR #30306:
URL: https://github.com/apache/camel/pull/30306#discussion_r4610959309


##########
components/camel-smpp/src/main/java/org/apache/camel/component/smpp/SmppConsumer.java:
##########
@@ -90,6 +93,7 @@ public SmppConsumer(SmppEndpoint endpoint, SmppConfiguration 
config, Processor p
     @Override
     protected void doStart() throws Exception {
         LOG.debug("Connecting to: {}...", getEndpoint().getConnectionString());
+        restartReconnectService();

Review Comment:
   💡 **Nit:** `restartReconnectService()` is called here _before_ 
`super.doStart()`, but in `SmppProducer.doStart()` it is called _after_. Both 
orderings are safe (reconnectService is not used by super.doStart()), but the 
two classes should be consistent. Pick one order and apply it to both.



##########
components/camel-smpp/src/main/java/org/apache/camel/component/smpp/SmppUtils.java:
##########
@@ -321,7 +321,7 @@ public static ScheduledExecutorService 
createExecutor(BaseService service, Endpo
         }
     }
 
-    public static BlockingTask newReconnectTask(
+    public static BackgroundTask newReconnectTask(

Review Comment:
   ⚠️ **Missing upgrade guide entry:** This `public static` method's return 
type changes from `BlockingTask` to `BackgroundTask` — a binary-incompatible 
change. Any caller compiled against the old signature (assigning the return 
value to a `BlockingTask` variable) will get a `NoSuchMethodError` at runtime. 
Add a brief entry to 
`docs/user-manual/modules/ROOT/pages/camel-4x-upgrade-guide-4_24.adoc`:
   
   ```
   === camel-smpp - SmppUtils.newReconnectTask return type
   
   `SmppUtils.newReconnectTask` now returns `BackgroundTask` instead of 
`BlockingTask`.
   Recompile any code that calls this method and assigns the result to a 
`BlockingTask` variable.
   ```
   
   If `SmppUtils` is confirmed as not called from outside the component, a note 
to that effect in the entry is sufficient.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to