davsclaus opened a new pull request, #1875:
URL: https://github.com/apache/camel-kafka-connector/pull/1875

   Fixes #1874
   
   ## What changed
   - The task masks the options of type `PASSWORD` in its "Setting initial 
properties in Camel context" log line, as well as the keys Camel knows as 
sensitive. A masked value shows as `xxxxxxx`, and the key stays visible.
   - The generated connectors have no task class of their own, so the task only 
knows the base configuration.
     - `CamelSourceConnector.taskConfigs()` and 
`CamelSinkConnector.taskConfigs()` now pass to the tasks the names of the 
connector's `PASSWORD` options that are set.
     - They go in the internal task property 
`camel.connector.passwordProperties`, the same way the connector defaults are 
passed. It holds names only, never values.
     - The task removes this property before it builds the Camel properties. It 
is not a user option and is not in the `ConfigDef`, so no connector docs change.
   - The task also masks the `PASSWORD` options that its own configuration 
class declares, for hand-written tasks.
   - New `CamelKafkaConnectMain.Builder.withPasswordProperties(...)`.
   - `security-model.adoc` now says that `PASSWORD` options are masked in that 
log line.
   
   ## Tests
   - New tests in `StartupPropertiesLoggingTest`:
     - the builder;
     - a source connector and a sink connector with a `PASSWORD` option, from 
`taskConfigs()` through the task start, checking that the property list does 
not reach the Camel properties;
     - a task whose own configuration class declares a `PASSWORD` option.
   - All 4 new tests fail without the change.
   - Core unit tests: 151 pass, run locally against Camel 4.22.3-SNAPSHOT 
because some 4.22.0 jars were missing locally. CI builds with the project's 
versions.
   
   ## Upgrade note
   None. The only visible change is that more values show as `xxxxxxx` in the 
startup log line.
   
   _Claude Code on behalf of Claus Ibsen_
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to