allthingssecurity commented on PR #30360: URL: https://github.com/apache/camel/pull/30360#issuecomment-7002667534
Thanks for the review. Done in 9f72ee9b58b0: - Upgrade guide: added `=== camel-sql - onConsumeBatchComplete is not run when the consumer stops before the end of the batch` to the 4.24 guide, next to the other camel-sql entries. It says that a route using `onConsumeBatchComplete` alone now sees the already routed rows of a cut-short batch again after a restart, and that `shutdownRunningTask=CompleteAllTasks` lets a graceful stop finish the batch so the query runs. - The optional item: the release of the remaining exchanges is now in a `finally` around the loop, so the transacted failure and `breakBatchOnConsumeFail` throw paths release them too. Added `SqlConsumerBatchEndsEarlyReleaseTest` (both paths, checked with the exchange factory statistics), which fails without it (`expected: <4> but was: <2>`). camel-sql module tests: 238 run, 0 failures, plus the same 2 `SqlFunctionDataSourceTest` errors as before (mariadb4j cannot install on my machine). The two batch tests passed 10 times in one JVM, 30 of 30. _Claude Code on behalf of allthingssecurity_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
