gnodet-bot commented on code in PR #30387:
URL: https://github.com/apache/camel/pull/30387#discussion_r4626872911
##########
pom.xml:
##########
@@ -121,11 +120,9 @@
<project.build.outputTimestamp>2026-10-15T12:33:02Z</project.build.outputTimestamp>
<sonar.java.source>${jdk.version}</sonar.java.source>
- <!-- NOTE: this is required to correctly map each module coverage in
Sonarqube. The ${maven.multiModuleProjectDirectory} may require some change
- when upgrading to Maven 4.x, according to any of the new variables
that will replace this one. -->
- <sonar.coverage.jacoco.xmlReportPaths>
-
${maven.multiModuleProjectDirectory}/coverage/target/site/jacoco-aggregate/jacoco.xml
- </sonar.coverage.jacoco.xmlReportPaths>
+ <!-- Each module reads its own coverage report, generated by
"jacoco:report@report-module" (see the Jenkinsfile).
+ Pointing every module to the aggregated report instead makes the
analysis parse that huge report once per module. -->
Review Comment:
💡 **Nit:** `sonar-build.yml` also generates these reports. Reference both.
```suggestion
<!-- Each module reads its own coverage report, generated by
"jacoco:report@report-module" (see the Jenkinsfile and sonar-build.yml).
Pointing every module to the aggregated report instead makes the
analysis parse that huge report once per module. -->
```
##########
pom.xml:
##########
@@ -716,6 +713,49 @@
</build>
<profiles>
+ <profile>
+ <!-- Merges the execution data collected in each module by the
"coverage" profile of the parent pom, in one file used to
+ generate the coverage report of each module
(jacoco:report@report-module, see the Jenkinsfile): some modules are
+ covered by the tests of other modules.
+ Not bound to the build, run it once the modules are built
with:
+ mvn -N -Pcoverage
org.jacoco:jacoco-maven-plugin:merge@merge-all -->
Review Comment:
💡 **Nit:** Same as above — `sonar-build.yml` also runs `merge@merge-all`.
Reference both.
```suggestion
<!-- Merges the execution data collected in each module by the
"coverage" profile of the parent pom, in one file used to
generate the coverage report of each module
(jacoco:report@report-module, see the Jenkinsfile and sonar-build.yml): some
modules are
covered by the tests of other modules.
Not bound to the build, run it once the modules are built
with:
mvn -N -Pcoverage
org.jacoco:jacoco-maven-plugin:merge@merge-all -->
```
##########
parent/pom.xml:
##########
@@ -4670,6 +4670,25 @@
</excludes>
</configuration>
</execution>
+ <!-- Generates the coverage report of one module
from the execution data of all the modules
+ merged by the "coverage" profile of the root
pom (some modules are covered by the tests of other modules).
+ Not bound to the build: run it with "mvn
-Pcoverage jacoco:report@report-module"
+ after the merge of the execution data, see
the Jenkinsfile. -->
Review Comment:
💡 **Nit:** `sonar-build.yml` also invokes `jacoco:report@report-module` (via
`-Dcoverage`). Reference both CI scripts so readers know where to look.
```suggestion
<!-- Generates the coverage report of one module
from the execution data of all the modules
merged by the "coverage" profile of the
root pom (some modules are covered by the tests of other modules).
Not bound to the build: run it with "mvn
-Pcoverage jacoco:report@report-module"
after the merge of the execution data, see
the Jenkinsfile and sonar-build.yml. -->
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]