gnodet-bot commented on code in PR #30399:
URL: https://github.com/apache/camel/pull/30399#discussion_r4627912461


##########
docs/user-manual/modules/ROOT/pages/camel-4x-upgrade-guide-4_18.adoc:
##########
@@ -1036,6 +1036,46 @@ that header, and says when `operationName` is set, in 
place of `Cannot find meth
 no longer sends it as an HTTP header, with either client API. The 
`SimpleConsumer` binding no longer returns it as a
 response header.
 
+=== camel-core - option values of a dynamic endpoint are bound as literal text
+
+The dynamic-endpoint EIPs -- `toD`, `enrich`, `wireTap`, `pollEnrich`, 
`recipientList`, `routingSlip` and
+`dynamicRouter` -- compute their target endpoint from the current message at 
runtime. The option values of that
+endpoint are now bound as literal text: a `#class:` value or a `#property:` 
value is not resolved. It applies however the component binds its options, 
including components that bind them in their

Review Comment:
   💡 **Low:** Same `"It applies however the component binds its options"` 
ambiguity as above — `however` reads as a conjunction. Suggest:
   
   ```suggestion
   endpoint are now bound as literal text: a `#class:` value or a `#property:` 
value is not resolved. This applies regardless of how the component binds its 
options, including components that bind them in their
   ```



##########
docs/user-manual/modules/ROOT/pages/camel-4x-upgrade-guide-4_22.adoc:
##########
@@ -992,6 +992,52 @@ The failure no longer reaches the error handler of the 
route (such as an `onExce
 unless `bridgeErrorHandler=true`. With `pollOnError=STOP`, the consumer now 
reconnects in this case instead of
 stopping.
 
+=== camel-core - option values of a dynamic endpoint are bound as literal text
+
+The dynamic-endpoint EIPs -- `toD`, `enrich`, `wireTap`, `pollEnrich`, 
`recipientList`, `routingSlip` and
+`dynamicRouter` -- compute their target endpoint from the current message at 
runtime. The option values of that
+endpoint are now bound as literal text: a property placeholder (`+{{...}}+`), 
a `#class:` value or a `#property:` value
+is not resolved. This extends to the options the treatment that `toD`, 
`enrich`, `wireTap` and `pollEnrich` already gave
+the endpoint path. It applies however the component binds its options, 
including components that bind them in their

Review Comment:
   💡 **Low:** Two doc-clarity issues here: (1) `"the options the treatment 
that"` reads as if `"same"` is missing; (2) `"It applies however"` is ambiguous 
— `however` reads as a conjunction ("but") rather than meaning "regardless of 
how".
   
   ```suggestion
   is not resolved. This extends to the options the same treatment that `toD`, 
`enrich`, `wireTap` and `pollEnrich` already gave
   the endpoint path. This applies regardless of how the component binds its 
options, including components that bind them in their
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to