lobtx opened a new pull request, #30400:
URL: https://github.com/apache/camel/pull/30400

   # Description
   
   Follow-up of #30303, from the review: the block that overrides the 
properties of the properties component with the OS environment variables and 
then the JVM system properties was repeated in six methods of `BaseMainSupport`.
   
   ## Change
   
   - `overrideWithEnvironmentAndSystemProperties(prop, prefixes...)`: ENV, then 
SYS, with `putAllOverride` and the debug logs. It is used by 
`lookupEarlyOption`, `autoConfigurationFailFast`, 
`autoConfigurationSingleOption`, `doConfigureVaultFromMainConfiguration`, 
`doConfigureCamelContextFromMainConfiguration` and 
`autoConfigurationPropertiesComponent`.
   - `loadEarlyProperties`: the options needed before the CamelContext is built 
are loaded once and shared by virtual threads and type converter statistics, 
instead of once per option.
   
   Two similar blocks are left as they are, as they differ: 
`autoConfigurationStartupConditions` uses `putAll`, not `putAllOverride`, and 
`autoConfigurationMainConfiguration` removes some keys from ENV and SYS before 
merging them.
   
   No change of behavior.
   
   ## Tests
   
   - camel-main tests (358).
   - A standalone Camel Main application started with the same mix of sources 
(`application.properties`, six environment variables and three JVM system 
properties, on `camel.main.`, `camel.threadpool.` and 
`camel.component.properties.`), on main and on this branch: the auto 
configuration summary (with the source of each option) and the resulting values 
are the same. Same with 
`camel.main.autoConfigurationEnvironmentVariablesEnabled = false`.
   
   AI tool used: Claude Code (Claude Opus 5.5), reviewed and checked by me.
   
   _Claude Code on behalf of lobtx_
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to