christophd commented on code in PR #3263:
URL: https://github.com/apache/camel-kamelets/pull/3263#discussion_r4629529000
##########
kamelets/crypto-decrypt-action.kamelet.yaml:
##########
@@ -39,7 +39,7 @@ spec:
Output: the body is the original data, as bytes (a stream). The headers
are kept.
- Good to know: data that was changed, or a different `algorithm`, `mode`
or `key` than when encrypting, fails the message with "Message authentication
failed". The key is a secret; keep it in a vault or a secret, not in plain
configuration.
+ Good to know: the `Content-Type` header is kept as it comes, which after
`crypto-encrypt-action` is `application/octet-stream`: set it again to the type
of the original data when the next step needs it, for example with
`insert-header-action`. data that was changed, or a different `algorithm`,
`mode` or `key` than when encrypting, fails the message with "Message
authentication failed". The key is a secret; keep it in a vault or a secret,
not in plain configuration.
Review Comment:
Minor: "data" after the period should be capitalized — it's now the start of
a new sentence.
```suggestion
Good to know: the `Content-Type` header is kept as it comes, which
after `crypto-encrypt-action` is `application/octet-stream`: set it again to
the type of the original data when the next step needs it, for example with
`insert-header-action`. Data that was changed, or a different `algorithm`,
`mode` or `key` than when encrypting, fails the message with "Message
authentication failed". The key is a secret; keep it in a vault or a secret,
not in plain configuration.
```
(Same change needed in
`library/camel-kamelets/src/main/resources/kamelets/crypto-decrypt-action.kamelet.yaml`
and the `kamelets-index.json` entry.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]