oscerd commented on code in PR #30332:
URL: https://github.com/apache/camel/pull/30332#discussion_r4631854130


##########
docs/user-manual/modules/ROOT/pages/security-policy.adoc:
##########
@@ -37,6 +37,11 @@ an option that merely has the same name as an insecure 
option of another compone
 camel-hivemq) is not flagged. Any other property (such as 
`camel.ssl.trustAllCertificates`) is checked by the
 option name.
 
+The properties of the beans that YAML and XML route files define in their 
`beans` section are checked once the routes
+are loaded, under the key of a bean configured from properties: 
`camel.beans.<name>.<property>`, such as
+`camel.beans.opaPolicy.failOpen`. The same key goes in 
`camel.security.allowedProperties` to allow one of them. The
+options set in the endpoint URIs of the routes are not checked.

Review Comment:
   Thanks. I reworded it to state the scope of the security policy, with an 
example, but without the parenthetical: nothing checks the endpoint URI options 
for security instead. The component validates their names and types only, so 
`opa:authz/allow?failOpen=true` starts with `camel.main.profile=prod` (checked 
with `camel run` on 4.23.0). Checking them would be the route-level URI 
scanning listed as future work in `design/security.adoc`.
   
   _Claude Code on behalf of oscerd_
   



##########
docs/user-manual/modules/ROOT/pages/security-policy.adoc:
##########
@@ -37,6 +37,13 @@ an option that merely has the same name as an insecure 
option of another compone
 camel-hivemq) is not flagged. Any other property (such as 
`camel.ssl.trustAllCertificates`) is checked by the
 option name.
 
+With camel-main and the Camel CLI, the properties of the beans that route 
files define (the `beans` section of a YAML
+or XML DSL file, and the beans of a Spring XML or Blueprint XML file) are 
checked once the routes are loaded, under the
+key of a bean configured from properties: `camel.beans.<name>.<property>`, 
such as `camel.beans.opaPolicy.failOpen`.
+The same key goes in `camel.security.allowedProperties` to allow one of them. 
Camel Spring Boot checks the
+configuration properties only, not the beans of route files. The options set 
in the endpoint URIs of the routes are
+not checked.

Review Comment:
   Thanks. I reworded it to state the scope of the security policy, with an 
example, but without the parenthetical: nothing checks the endpoint URI options 
for security instead. The component validates their names and types only, so 
`opa:authz/allow?failOpen=true` starts with `camel.main.profile=prod` (checked 
with `camel run` on 4.23.0). Checking them would be the route-level URI 
scanning listed as future work in `design/security.adoc`.
   
   _Claude Code on behalf of oscerd_
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to