Croway commented on PR #30449: URL: https://github.com/apache/camel/pull/30449#issuecomment-7021212597
Thanks @davsclaus. Checked against the Spring AI 2.1.0 sources (`SessionContexts.sessionId` throws without the id, `DefaultSessionService` has a 60-day time to live and nothing removes expired sessions by itself), and applied all of it in 07a94e5ab6a4: - The NOTE now says the header only gates the memory of the endpoint; session advisors passed with `advisors` need it on every exchange, or they fail with `No session ID found in advisor context` (a `MessageChatMemoryAdvisor` uses a default id). - A configured `chatClient` with its own memory advisor still gets the endpoint memory advisor when a `SessionService` or `ChatMemory` bean is autowired: documented in the session section and in the upgrade guide, with the two ways out (`advisors` option, or `autowiredEnabled=false`). - Retention: a session keeps every event, expired sessions are only removed by `SessionService.deleteExpiredSessions`, with a timer route example; also in the guide. - An IMPORTANT note to derive the conversation id from an authenticated identity, as a session is created for any id. - The `advisors` option Javadoc and the `CamelSpringAiChatConversationId` description no longer mention chat memory only; regenerated. - CAMEL-27243 now lists the two small changes for existing routes, and has fixVersion 4.24.0. _Claude Code on behalf of Croway_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
