davsclaus opened a new issue, #3291:
URL: https://github.com/apache/camel-kamelets/issues/3291

   `github-pullrequest-source`, `github-pullrequest-comment-source` and 
`github-tag-source` turn the object the `github2` component gives 
(`GHPullRequest`, `GHIssueComment`, `GHTag` of the `org.kohsuke:github-api` 
library) into JSON with `marshal: json`. Jackson then calls every getter of the 
object, and many of these getters read more from the GitHub API on their own: a 
pull request loads its details (`getAdditions()`, `getMergeable()`), a commit 
and a user populate themselves, a repository lists its branches, collaborators 
and so on.
   
   So each message makes extra GitHub API requests besides the poll, and any of 
them that fails (rate limit, 404, missing permission) fails the message. The 
consumer has already moved past it, so the message is lost.
   
   Reproduced with the GitHub API stand-in of the Citrus tests 
(`GitHubApiStub`), one new item per Kamelet:
   
   | Kamelet | Extra requests made while marshalling one message | Failure |
   |---|---|---|
   | `github-tag-source` | `repos/<o>/<r>/commits/<sha>` 
(`GHTag["commit"]->GHCommit["author"]`), then `users/<login>`, 
`users/<login>/followers`, ... | `DatabindException` at `marshal1`, message not 
delivered |
   | `github-pullrequest-source` | `repos/<o>/<r>/pulls/<n>`, then 
`repos/<o>/<r>/commits/<sha>`, ... | same |
   | `github-pullrequest-comment-source` | `repos/<o>/<r>/pulls/<n>` 
(`GHIssueComment["parent"]->GHPullRequest["additions"]`), ... | same |
   
   Each answered request leads to the next getter that reads more, so against 
github.com one message costs many requests of the rate limit of the token.
   
   The output should be built from the data the poll already returned, without 
more requests.
   
   _Claude Code on behalf of Claus Ibsen_
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to