allthingssecurity commented on PR #30466:
URL: https://github.com/apache/camel/pull/30466#issuecomment-7033555565

   Thanks for the review.
   
   1. Upgrade guide entry added (2d5c54ec2937), right after the "camel-box - 
getEnterpriseEvents" one: `box:events/listen` no longer routes an exchange with 
a `null` body at every poll (500 ms by default), and the consumer listens again 
after the event stream fails (after 1 s, doubled after each failure up to 60 s, 
from the position after the last events received). About `BoxEventsManagerIT`: 
right, `expectedMinimumMessageCount(2)` was met by the empty exchanges until 
now; with the fix it needs two real events from position 0 in the test account. 
I left the IT as it is (it needs a Box account and was not run locally).
   2. No change here: when `doStart` throws, `BaseService.start()` calls 
`stop()` before it fails the service (`BaseService.java:135-139`). The status 
is still STARTING then, so `doStop` runs, and `doStop` shuts the restart 
executor down through the `ExecutorServiceManager` and stops listening. So a 
failed initial listen does not leave the executor registered. A try/catch in 
`doStart` would do the same thing a second time.
   3. I would keep it as it is: each failed stream goes to the exception 
handler, and a failed restart attempt is DEBUG, which keeps a long outage at 
one WARN per failed stream. Happy to switch to the first-failure-then-DEBUG 
rule of #30465 if you prefer it.
   
   camel-box-component unit tests after the commit: 11 run, 0 failures.
   
   _Claude Code on behalf of allthingssecurity_
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to