ramu11 commented on PR #30481:
URL: https://github.com/apache/camel/pull/30481#issuecomment-7035883646
Thanks @davsclaus for the detailed review. I have addressed the feedback in
commit **`6bd2f6a6386a`**, now pushed to the PR branch.
Changes in this commit:
1. **Poll failure handling:** A poll only fails when it starts from the
beginning of the listing and no blobs can be retrieved. Failures in a remaining
listing tail are reported through the configured exception handler.
2. **Regex and page size:** Automatic page-size reduction is skipped when
regex filtering is configured. Explicit `maxResultsPerPage` settings continue
to be respected.
3. **Unit test coverage:**
- Parameterized the existing failed-get and deleted-blob regression tests
to cover both the default unlimited behavior and `maxMessagesPerPoll=2`.
- Added mock-based multi-page listing tests covering archived blobs on a
later page, page remainder retention, continuation-token handling, wraparound,
and cleanup when a later page fails.
- Added tests for the regex/page-size behavior.
4. **Integration tests:** Removed the timing dependency on
`initialDelay=5000` by disabling automatic route startup and starting the route
after uploading the blobs. Also added route restart coverage to verify that the
listing cursor resets.
5. **Lifecycle and defensive handling:** Reset the listing cursor on
consumer restart and use `ObjectHelper.isEmpty()` for continuation-token
completion.
6. **Documentation:** Added Java and YAML examples, clarified the
successful-get counting behavior and bounded-prefetch semantics, and clarified
that `maxResultsPerPage` controls the listing page size.
7. Updated the corresponding generated Azure Blob metadata and DSL artifacts.
**Local test results:**
- 32 targeted unit tests passed.
- 7 `BlobConsumerIT` integration tests passed.
- 39 tests total, with 0 failures and 0 errors.
Regarding strict just-in-time retrieval: I have intentionally kept the
bounded-prefetch approach in this PR so that Camel's `CamelBatchSize`,
`CamelBatchIndex`, and `CamelBatchComplete` properties remain exact.
Thanks again for the review and suggestions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]