gnodet-bot commented on code in PR #30491:
URL: https://github.com/apache/camel/pull/30491#discussion_r4641656444
##########
components/camel-ai/camel-ai-tool/src/main/java/org/apache/camel/component/ai/tool/AiToolConfiguration.java:
##########
@@ -38,7 +38,10 @@ public class AiToolConfiguration implements Cloneable {
@Metadata(label = "consumer")
@UriParam(description = "Comma-separated list of tags used to group tools.
"
+ "Producers filter the registry by these tags to
select which tools to expose to the LLM. "
- + "When omitted, the tool goes into a default pool
available to all producers.")
+ + "When omitted, the tool goes into a default pool
that is added to the tools of every tag "
+ + "a producer selects with its own tags option "
+ + "(producers without tags receive no registry
tools, "
+ + "and the MCP server never exposes the default
pool).")
Review Comment:
The description is a 42-word run-on with passive voice ("is added to the
tools of every tag"). Three distinct ideas could be split across shorter
sentences for better scannability:
- "When omitted, the tool joins a default pool."
- "Tagged producers always receive the default pool in addition to their own
tag's tools."
- "Producers without tags receive no registry tools, and the MCP server
never exposes the default pool."
_This review was generated by an AI agent, Hermès on behalf of @gnodet._
<!-- reviewer: gnodet-bot -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]