Croway commented on code in PR #30490:
URL: https://github.com/apache/camel/pull/30490#discussion_r4641704834


##########
components/camel-debezium/camel-debezium-common/camel-debezium-common-component/pom.xml:
##########
@@ -54,6 +54,32 @@
             <artifactId>lz4-java</artifactId>
             <version>${lz4-java-version}</version>
         </dependency>
+        <!-- Kafka Connect of the same version as kafka-clients (Kafka moves 
internal classes between minor versions) -->
+        <dependency>
+            <groupId>org.apache.kafka</groupId>
+            <artifactId>connect-api</artifactId>
+            <version>${kafka-version}</version>
+        </dependency>
+        <dependency>
+            <groupId>org.apache.kafka</groupId>
+            <artifactId>connect-json</artifactId>
+            <version>${kafka-version}</version>
+        </dependency>
+        <dependency>
+            <groupId>org.apache.kafka</groupId>
+            <artifactId>connect-runtime</artifactId>

Review Comment:
   `connect-runtime` has to stay in compile scope: `DebeziumConstants` imports 
`org.apache.kafka.connect.storage.FileOffsetBackingStore` (the default 
`offsetStorage`), which is in `connect-runtime`. With `<scope>runtime</scope>` 
the module no longer compiles (`DebeziumConstants.java:[20,40] cannot find 
symbol`).
   
   It also does not expose anything new to downstream modules: 
`debezium-embedded` already declares `connect-runtime` in compile scope, this 
PR only changes its version from 4.3.1 to `${kafka-version}`.
   
   _Claude Code (Opus 5.5) on behalf of Federico Mariani_
   



##########
components/camel-debezium/camel-debezium-common/camel-debezium-common-component/pom.xml:
##########
@@ -54,6 +54,32 @@
             <artifactId>lz4-java</artifactId>
             <version>${lz4-java-version}</version>
         </dependency>
+        <!-- Kafka Connect of the same version as kafka-clients (Kafka moves 
internal classes between minor versions) -->
+        <dependency>
+            <groupId>org.apache.kafka</groupId>
+            <artifactId>connect-api</artifactId>
+            <version>${kafka-version}</version>
+        </dependency>
+        <dependency>
+            <groupId>org.apache.kafka</groupId>
+            <artifactId>connect-json</artifactId>
+            <version>${kafka-version}</version>
+        </dependency>
+        <dependency>
+            <groupId>org.apache.kafka</groupId>
+            <artifactId>connect-runtime</artifactId>
+            <version>${kafka-version}</version>
+        </dependency>
+        <dependency>
+            <groupId>org.apache.kafka</groupId>
+            <artifactId>connect-transforms</artifactId>

Review Comment:
   Right, today it would resolve to 4.4.0 through `connect-runtime` anyway 
(`debezium-connector-postgres` declares it too, but in `provided` scope). It is 
listed on purpose, as the comment above the block says: every Kafka Connect 
module on Debezium's classpath is pinned to the `kafka-clients` version, so 
none of them falls back to Debezium's Kafka version if a future Debezium 
release declares it directly.
   
   About #27876: Dependabot closes it on its own once this is merged and 
`kafka-clients` 4.4.0 is on main.
   
   _Claude Code (Opus 5.5) on behalf of Federico Mariani_
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to