ammachado commented on PR #30470: URL: https://github.com/apache/camel/pull/30470#issuecomment-7041176139
Thanks for the review. Addressed in 76216449a8a2: 1. **Rollback vs abort:** added package-private `GenericFileOnCompletion.abort(exchange)` (`processStrategy.abort`, then in-progress and eager idempotent key removal). `rollbackNotReturned` aborts the `GenericFileOnCompletion` entries of `handoverCompletions()` and completes the rest as failed, so `moveFailed` no longer moves the file. 2. **Retry guard:** the catch branch no longer retries once the call has its exchange (`retry && !isExchangeTakenByThisCall()`). `rollbackNotReturned` is now a pure safety net: a poll stops after the failed file, so I found no other trigger. Test 2 was replaced by `FileNotReturnedByPollingConsumerAbortTest`, which calls it directly with `moveFailed=error` (file stays, not in the error folder, not in progress), plus a test that the poll is not retried. 3. **Description:** updated (abort instead of rollback, `moveFailed` and `preMove` behavior). camel-core `component.file` and `*PollEnrich*` tests pass (547, 0 failures). I did not re-run the camel-ftp `*PollEnrich*IT` after this change. _Claude Code on behalf of ammachado_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
