davsclaus opened a new pull request, #3359:
URL: https://github.com/apache/camel-kamelets/pull/3359

   With CAMEL-27389 (apache/camel#30603), Camel JBang and Camel Main serve a 
cxf consumer on the platform-http server, under the base path `camel.cxf.path` 
(`/services` by default, the same as `cxf.path` on Spring Boot and 
`quarkus.cxf.path` on Quarkus). A full URL as the address of a cxf consumer now 
fails at route start. This PR changes `soap-source` to match.
   
   **Stacked on #3357** (the JSON mode), because both change `soap-source`. 
Until #3357 is merged, the diff also shows its commits; this PR's own change is 
the last commit.
   
   ## Changes
   
   - `soap-source`: the option `address` (a full URL such as 
`http://0.0.0.0:8080/orders`) is replaced by `path`, such as `/orders`, with 
the pattern `^/[^?#]*$`. The template uses `cxf:{{path}}`. The Kamelet is 
Preview and is not released yet, so the rename breaks nobody; an option called 
`address` that holds a path would confuse integrators and AI assistants that 
read only the YAML.
   - The description says where the service is: `path` under `/services` on the 
HTTP server of the integration (`http://localhost:8080/services/orders` with 
Camel JBang), the WSDL at the same URL with `?wsdl`, and port, TLS and network 
interface from `camel.server.*`. The advice about `0.0.0.0` is gone.
   - `publishedEndpointUrl`: without it, the WSDL gives the host of the 
request's `Host` header. The `X-Forwarded-*` headers of a proxy are used only 
with `camel.cxf.useXForwardedHeaders=true`.
   - `soap-action` is unchanged, since a cxf producer still takes a full URL.
   - Tests: every SOAP test integration sets `camel.server.port` to its own 
port, the `soap-source` routes use `path`, and the clients call 
`/services/orders`.
   
   ## Tested
   
   Against a local Camel reactor build of main with 79ad77e0b116:
   - `SoapIT` 4/4: soap-front-backend, soap-json, soap-soap12 and soap-wssec.
   - By hand with `camel run`, `soap12-route.yaml` on port 18555:
     - the log says `cxf consumer served on the platform-http server at 
/services/orders`;
     - `?wsdl` gives `http://localhost:18555/services/orders`, and with `Host: 
orders.example.com:9999` it gives 
`http://orders.example.com:9999/services/orders`;
     - `X-Forwarded-Host`/`-Proto`/`-Port` are ignored by default, and with 
`camel.cxf.useXForwardedHeaders=true` it gives 
`https://proxy.example.com/services/orders`;
     - the old path `/orders?wsdl` answers 404.
   
   CI needs a Camel snapshot that has 79ad77e0b116. The one published at 13:32 
UTC today does not have it.
   
   ## Upgrade note
   
   None: `soap-source` is new in 4.24, and the "New Kamelets" entry in #3190 
will say `path`.
   
   _Claude Code on behalf of Claus Ibsen_
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   
   https://claude.ai/code/session_016Y4dDmBDsSWV117kccuNf9
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to