gnodet-bot commented on code in PR #30616:
URL: https://github.com/apache/camel/pull/30616#discussion_r4659814949


##########
dsl/camel-jbang/camel-jbang-mcp/pom.xml:
##########
@@ -128,6 +128,11 @@
         </dependency>
 
         <!-- rest-openapi component: the OpenAPI tools follow its rules 
(generated operation ids) -->
+        <!-- the wsdl tools -->

Review Comment:
   💡 **Nit:** The existing `<!-- rest-openapi component: ... -->` comment at 
line 130 now appears to describe this WSDL block rather than the 
`camel-rest-openapi` dependency below. Consider swapping the order: put `<!-- 
the wsdl tools -->` + `camel-jbang-wsdl` first, then `<!-- rest-openapi 
component: ... -->` immediately above `camel-rest-openapi`.



##########
dsl/camel-jbang/camel-jbang-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/EndpointsTab.java:
##########
@@ -448,6 +467,53 @@ void selectEndpoint(String uri, String routeId) {
     }
 
     /** The endpoint selected in the table, as filtered and sorted. */
+    /** Whether the bottom panel is the detail or the WSDL of the endpoint 
(text with focus and scroll). */

Review Comment:
   💡 **Nit:** This new Javadoc is inserted immediately after the existing `/** 
The endpoint selected in the table, as filtered and sorted. */` at line 469. In 
Java, only the *last* `/** */` before a declaration attaches to it — the 
original `selectedEndpoint()` Javadoc is now orphaned and `selectedEndpoint()` 
(at line 517) ends up undocumented. Move the original Javadoc to sit 
immediately above `selectedEndpoint(IntegrationInfo info)`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to