ppalaga commented on issue #617: Build time Camel service resolution
URL: https://github.com/apache/camel-quarkus/issues/617#issuecomment-574077814
 
 
   In general, I do not mind prefering the Camel registry. It is there and can 
serve the purpose of instantiating services well.
   
   The problem I am trying to solve here is, that we (camel-quarkus) still have 
code assuming that the FactoryFinders work well (incl. native), which they 
currently don't. I see several options how to fix that:
   
   A. Brute force: always add all service property files to the native image 
and keep using `DefaultFactoryFinderResolver` / `DefaultFactoryFinder` which 
read the files at runtime.
   
   B. Totally avoid using FactoryFinders. Provide an exception throwing 
FactoryFinder to make sure that our extensions do not use it at all. I am not 
sure this is possible and I am not sure this is a good idea, because third 
party extensions may still assume the FactoryFinders work.
   
   C. My original proposal: Custom FactoryFinder assembled at build time, no 
need to include the property files in the native image.
   
   Both A. and C. sound like acceptable solutions to me, C. being more in 
accordance with the spirit of Quarkus.
   
   WDYT?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to