orpiske commented on issue #85: First step for issue #15 URL: https://github.com/apache/camel-kafka-connector/pull/85#issuecomment-583489234 > So @omarsmak @orpiske @oscerd I need your input and view on this (and form whoever likes to participate in the conversation). > > As you can see there are 3 main parts to this PR: > > * changes to `core/`: these are to enable pre-configuration of a connector by subclassing `Camel{Sink,Source}Connector` and `Camel{Sink,Source}Task` and providing the initial configuration through an override of `getDefaultConfig()`. Everything is still configurable through the property file supplied when you run the connector since those properties have precedence. All will still work with the old `camel.{sink,source}.url` config since if this one is present all the properties `camel.endpoint` `camel.path` and `camel.{sink,source}.component` will be ignored. If `camel.{sink,source}.url` is null though, the url is assembled by combining `camel.{sink,source}.component` and `camel.endpoint` `camel.path` accordingly. > > * in `connectors/camel-sjms2-kafka-connector` there is the sjms2 connector done by hand has it should be generated. > > * in `tooling/` I have pre imported the maven plugins from camel-spring-boot project, but those are not functional, will serve as a base for the prosecution of my work: the actual generations. > > > That said here is my question: if you look at `CamelSjms2SinkConnectorConfig` and `CamelSjms2SourceConnectorConfig` in `connectors/camel-sjms2-kafka-connector` you see that there are all those kafka connector properties definitions that can be generated parsing the `camel-catalog`; has that much value-added? Those properties are never used in the code, they are there only for documentation resons, would be better to just generate good, tweaked for connectors, documentation starting from the catalog? This looks very good. My only comment here is regarding the properties. I think that even if they are not used in the code, there may be some value on them if they can be used for documentation properties. Even if they are not directly used, folks reading the code may still find some value in them. Everything else looks fine to me and I'm looking forward the changes.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
