This is an automated email from the ASF dual-hosted git repository. acosentino pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/camel.git
commit 79c73e342e45cb33703aba62f94c483abe0b38ad Author: Andrea Cosentino <[email protected]> AuthorDate: Tue Apr 7 10:26:26 2020 +0200 CAMEL-14850 - Camel-AWS2-*: Improve the verifiers to check if a particular service works on a specified region, Kinesis Firehose --- .../KinesisFirehose2ComponentVerifierExtension.java | 5 +++++ .../KinesisFirehoseComponentVerifierExtensionTest.java | 16 ++++++++++++++++ 2 files changed, 21 insertions(+) diff --git a/components/camel-aws2-kinesis/src/main/java/org/apache/camel/component/aws2/firehose/KinesisFirehose2ComponentVerifierExtension.java b/components/camel-aws2-kinesis/src/main/java/org/apache/camel/component/aws2/firehose/KinesisFirehose2ComponentVerifierExtension.java index c6e9c8c..e5d8ff6 100644 --- a/components/camel-aws2-kinesis/src/main/java/org/apache/camel/component/aws2/firehose/KinesisFirehose2ComponentVerifierExtension.java +++ b/components/camel-aws2-kinesis/src/main/java/org/apache/camel/component/aws2/firehose/KinesisFirehose2ComponentVerifierExtension.java @@ -18,6 +18,7 @@ package org.apache.camel.component.aws2.firehose; import java.util.Map; +import org.apache.camel.component.extension.ComponentVerifierExtension.VerificationError; import org.apache.camel.component.extension.verifier.DefaultComponentVerifierExtension; import org.apache.camel.component.extension.verifier.ResultBuilder; import org.apache.camel.component.extension.verifier.ResultErrorBuilder; @@ -67,6 +68,10 @@ public class KinesisFirehose2ComponentVerifierExtension extends DefaultComponent try { KinesisFirehose2Configuration configuration = setProperties(new KinesisFirehose2Configuration(), parameters); + if (!FirehoseClient.serviceMetadata().regions().contains(Region.of(configuration.getRegion()))) { + ResultErrorBuilder errorBuilder = ResultErrorBuilder.withCodeAndDescription(VerificationError.StandardCode.ILLEGAL_PARAMETER, "The service is not supported in this region"); + return builder.error(errorBuilder.build()).build(); + } AwsBasicCredentials cred = AwsBasicCredentials.create(configuration.getAccessKey(), configuration.getSecretKey()); FirehoseClientBuilder clientBuilder = FirehoseClient.builder(); FirehoseClient client = clientBuilder.credentialsProvider(StaticCredentialsProvider.create(cred)).region(Region.of(configuration.getRegion())).build(); diff --git a/components/camel-aws2-kinesis/src/test/java/org/apache/camel/component/aws2/firehose/KinesisFirehoseComponentVerifierExtensionTest.java b/components/camel-aws2-kinesis/src/test/java/org/apache/camel/component/aws2/firehose/KinesisFirehoseComponentVerifierExtensionTest.java index 1ca2364..d6fa62e 100644 --- a/components/camel-aws2-kinesis/src/test/java/org/apache/camel/component/aws2/firehose/KinesisFirehoseComponentVerifierExtensionTest.java +++ b/components/camel-aws2-kinesis/src/test/java/org/apache/camel/component/aws2/firehose/KinesisFirehoseComponentVerifierExtensionTest.java @@ -68,5 +68,21 @@ public class KinesisFirehoseComponentVerifierExtensionTest extends CamelTestSupp assertEquals(ComponentVerifierExtension.Result.Status.ERROR, result.getStatus()); } + + @Test + public void testConnectivityAndRegion() throws Exception { + Component component = context().getComponent("aws2-kinesis-firehose"); + ComponentVerifierExtension verifier = component.getExtension(ComponentVerifierExtension.class).orElseThrow(IllegalStateException::new); + + Map<String, Object> parameters = new HashMap<>(); + parameters.put("secretKey", "l"); + parameters.put("accessKey", "k"); + parameters.put("region", "l"); + parameters.put("streamName", "test"); + + ComponentVerifierExtension.Result result = verifier.verify(ComponentVerifierExtension.Scope.CONNECTIVITY, parameters); + + assertEquals(ComponentVerifierExtension.Result.Status.ERROR, result.getStatus()); + } }
