davsclaus commented on a change in pull request #3824:
URL: https://github.com/apache/camel/pull/3824#discussion_r424931092
##########
File path:
components/camel-webhook/src/main/java/org/apache/camel/component/webhook/WebhookEndpoint.java
##########
@@ -91,11 +98,17 @@ protected void doStart() throws Exception {
@Override
protected void doStop() throws Exception {
super.doStop();
-
if (configuration.isWebhookAutoRegister() && delegateEndpoint != null)
{
LOG.info("Unregistering webhook for endpoint: {}",
delegateEndpoint);
delegateEndpoint.unregisterWebhook();
}
+ ServiceHelper.stopService(delegateEndpoint);
Review comment:
The webhook is creating the delegate endpoint and should handle its
lifecycle. That is how its done in other componens that does something like this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
