omarsmak commented on a change in pull request #3944:
URL: https://github.com/apache/camel/pull/3944#discussion_r444838616
##########
File path: components/camel-couchbase/pom.xml
##########
@@ -60,13 +60,13 @@
<dependency>
<groupId>org.apache.camel</groupId>
- <artifactId>camel-test-junit5</artifactId>
Review comment:
Any reason why not using junit5? We have done a lot of effort on junit5
migration
##########
File path: components/camel-couchbase/pom.xml
##########
@@ -23,7 +23,7 @@
<parent>
<groupId>org.apache.camel</groupId>
<artifactId>components</artifactId>
- <version>3.5.0-SNAPSHOT</version>
+ <version>3.4.0-SNAPSHOT</version>
Review comment:
master is on `3.5.0-SNAPSHOT`, this should change
##########
File path:
components/camel-couchbase/src/main/java/org/apache/camel/component/couchbase/CouchbaseComponent.java
##########
@@ -1,44 +1,44 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package org.apache.camel.component.couchbase;
-
-import java.util.Map;
-
-import org.apache.camel.CamelContext;
-import org.apache.camel.spi.annotations.Component;
-import org.apache.camel.support.DefaultComponent;
-
-/**
- * Couchbase component.
- */
-@Component("couchbase")
-public class CouchbaseComponent extends DefaultComponent {
-
- public CouchbaseComponent() {
- }
-
- public CouchbaseComponent(CamelContext context) {
- super(context);
- }
-
- @Override
- protected CouchbaseEndpoint createEndpoint(String uri, String remaining,
Map<String, Object> parameters) throws Exception {
- CouchbaseEndpoint endpoint = new CouchbaseEndpoint(uri, remaining,
this);
- setProperties(endpoint, parameters);
- return endpoint;
- }
-}
+/*
Review comment:
Formatting here is bit troublesome as it shows it big change meanwhile
it is formatting
##########
File path:
components/camel-couchbase/src/main/java/org/apache/camel/component/couchbase/CouchbaseEndpoint.java
##########
@@ -37,21 +41,7 @@
import org.apache.camel.spi.UriPath;
import org.apache.camel.support.ScheduledPollEndpoint;
-import static
org.apache.camel.component.couchbase.CouchbaseConstants.COUCHBASE_PUT;
-import static
org.apache.camel.component.couchbase.CouchbaseConstants.COUCHBASE_URI_ERROR;
-import static
org.apache.camel.component.couchbase.CouchbaseConstants.DEFAULT_CONSUME_PROCESSED_STRATEGY;
-import static
org.apache.camel.component.couchbase.CouchbaseConstants.DEFAULT_COUCHBASE_PORT;
-import static
org.apache.camel.component.couchbase.CouchbaseConstants.DEFAULT_DESIGN_DOCUMENT_NAME;
-import static
org.apache.camel.component.couchbase.CouchbaseConstants.DEFAULT_MAX_RECONNECT_DELAY;
-import static
org.apache.camel.component.couchbase.CouchbaseConstants.DEFAULT_OBS_POLL_INTERVAL;
-import static
org.apache.camel.component.couchbase.CouchbaseConstants.DEFAULT_OBS_TIMEOUT;
-import static
org.apache.camel.component.couchbase.CouchbaseConstants.DEFAULT_OP_QUEUE_MAX_BLOCK_TIME;
-import static
org.apache.camel.component.couchbase.CouchbaseConstants.DEFAULT_OP_TIMEOUT;
-import static
org.apache.camel.component.couchbase.CouchbaseConstants.DEFAULT_PAUSE_BETWEEN_RETRIES;
-import static
org.apache.camel.component.couchbase.CouchbaseConstants.DEFAULT_PRODUCER_RETRIES;
-import static
org.apache.camel.component.couchbase.CouchbaseConstants.DEFAULT_READ_BUFFER_SIZE;
-import static
org.apache.camel.component.couchbase.CouchbaseConstants.DEFAULT_TIMEOUT_EXCEPTION_THRESHOLD;
-import static
org.apache.camel.component.couchbase.CouchbaseConstants.DEFAULT_VIEWNAME;
+import static org.apache.camel.component.couchbase.CouchbaseConstants.*;
Review comment:
Please retain from loading all statics through the wildcard
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
