lburgazzoli commented on a change in pull request #12:
URL: https://github.com/apache/camel-k-examples/pull/12#discussion_r453907821



##########
File path: 10-knative-source-salesforce/salesforce-source.yaml
##########
@@ -0,0 +1,32 @@
+#
+# Apache Camel Salesforce Source
+#
+apiVersion: sources.knative.dev/v1alpha1
+kind: CamelSource
+metadata:
+  name: camel-salesforce-source
+spec:
+  source:
+    integration:
+      configuration:
+        - type: secret
+          value: salesforce
+    flow:
+      from:
+        uri: salesforce:camelTestTopic

Review comment:
       maybe this should be `salesforce:{{salesforce.topic}}` to make it clear 
it is a parameter the user should set ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to