astefanutti commented on a change in pull request #1615:
URL: https://github.com/apache/camel-k/pull/1615#discussion_r455818960
##########
File path: pkg/apis/camel/v1/integration_types.go
##########
@@ -70,6 +70,7 @@ type IntegrationStatus struct {
//
+kubebuilder:printcolumn:name="Phase",type=string,JSONPath=`.status.phase`,description="The
integration phase"
//
+kubebuilder:printcolumn:name="Kit",type=string,JSONPath=`.status.kit`,description="The
integration kit"
//
+kubebuilder:printcolumn:name="Replicas",type=integer,JSONPath=`.status.replicas`,description="The
number of pods"
+//
+kubebuilder:resource:path=integrations,scope=Namespaced,shortName=it,categories=kamel;camel
Review comment:
ditto :)
##########
File path: pkg/apis/camel/v1/build_types.go
##########
@@ -147,6 +147,7 @@ const (
// Change format to 'duration' when CRD uses OpenAPI spec v3
(https://github.com/OAI/OpenAPI-Specification/issues/845)
//
+kubebuilder:printcolumn:name="Duration",type=string,JSONPath=`.status.duration`,description="The
build last execution duration"
//
+kubebuilder:printcolumn:name="Attempts",type=integer,JSONPath=`.status.failure.recovery.attempt`,description="The
number of execution attempts"
+//
+kubebuilder:resource:path=builds,scope=Namespaced,shortName=it,categories=kamel;camel
Review comment:
Could you append to the existing `kubebuilder:resource` marker instead
of duplicating it?
##########
File path: pkg/apis/camel/v1/camelcatalog_types.go
##########
@@ -75,6 +75,7 @@ type CamelCatalogStatus struct {
// +kubebuilder:subresource:status
// +kubebuilder:printcolumn:name="Runtime
Version",type=string,JSONPath=`.spec.runtime.version`,description="The Camel K
Runtime version"
// +kubebuilder:printcolumn:name="Runtime
Provider",type=string,JSONPath=`.spec.runtime.provider`,description="The Camel
K Runtime provider"
+//
+kubebuilder:resource:path=integrations,scope=Namespaced,shortName=it,categories=kamel;camel
Review comment:
ditto :)
##########
File path: pkg/apis/camel/v1/integrationkit_types.go
##########
@@ -57,6 +57,7 @@ type IntegrationKitStatus struct {
//
+kubebuilder:printcolumn:name="Phase",type=string,JSONPath=`.status.phase`,description="The
integration kit phase"
//
+kubebuilder:printcolumn:name="Type",type=string,JSONPath=`.metadata.labels.camel\.apache\.org\/kit\.type`,description="The
integration kit type"
//
+kubebuilder:printcolumn:name="Image",type=string,JSONPath=`.status.image`,description="The
integration kit image"
+//
+kubebuilder:resource:path=integrationkits,scope=Namespaced,shortName=it,categories=kamel;camel
Review comment:
ditto :) Mind the `shortName` value.
##########
File path: pkg/apis/camel/v1/integrationplatform_types.go
##########
@@ -54,6 +54,7 @@ type IntegrationPlatformStatus struct {
//
+kubebuilder:resource:path=integrationplatforms,scope=Namespaced,shortName=ip
// +kubebuilder:subresource:status
//
+kubebuilder:printcolumn:name="Phase",type=string,JSONPath=`.status.phase`,description="The
integration platform phase"
+//
+kubebuilder:resource:path=integrationplatforms,scope=Namespaced,shortName=it,categories=kamel;camel
Review comment:
ditto :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
