omarsmak commented on a change in pull request #4028: URL: https://github.com/apache/camel/pull/4028#discussion_r458617164
########## File path: components/camel-arangodb/src/main/java/org/apache/camel/component/arangodb/ArangoDbComponent.java ########## @@ -18,15 +18,44 @@ import java.util.Map; +import org.apache.camel.CamelContext; import org.apache.camel.Endpoint; +import org.apache.camel.spi.Metadata; +import org.apache.camel.spi.annotations.Component; import org.apache.camel.support.DefaultComponent; [email protected]("arangodb") +@Component("arangodb") public class ArangoDbComponent extends DefaultComponent { + @Metadata + private ArangoDbConfiguration configuration = new ArangoDbConfiguration(); + + public ArangoDbComponent() { + this(null); + } + + public ArangoDbComponent(CamelContext context) { + super(context); + } + protected Endpoint createEndpoint(String uri, String remaining, Map<String, Object> parameters) throws Exception { - Endpoint endpoint = new ArangoDbEndpoint(uri, this); + final ArangoDbConfiguration configuration = this.configuration != null ? this.configuration.copy() : new ArangoDbConfiguration(); + configuration.setDatabase(remaining); Review comment: since arango driver has default values, I don't see the need for the check here ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
