This is an automated email from the ASF dual-hosted git repository.

ajantha pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/carbondata.git


The following commit(s) were added to refs/heads/master by this push:
     new dd6b146  [HOTFIX] Remove unnecessary table status read
dd6b146 is described below

commit dd6b146445ed870362d474c9467fb93e3870c354
Author: Jacky Li <[email protected]>
AuthorDate: Thu Nov 14 20:00:27 2019 +0800

    [HOTFIX] Remove unnecessary table status read
    
    Remove 1 extra table status read in query flow
    
    This closes #3460
---
 .../src/main/scala/org/apache/spark/sql/hive/CarbonRelation.scala | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git 
a/integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonRelation.scala
 
b/integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonRelation.scala
index 04999a8..16dc43a 100644
--- 
a/integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonRelation.scala
+++ 
b/integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonRelation.scala
@@ -179,16 +179,16 @@ case class CarbonRelation(
       val tableStatusNewLastUpdatedTime = 
SegmentStatusManager.getTableStatusLastModifiedTime(
         carbonTable.getAbsoluteTableIdentifier)
       if (tableStatusLastUpdateTime != tableStatusNewLastUpdatedTime) {
-        if (new SegmentStatusManager(carbonTable.getAbsoluteTableIdentifier)
-          
.getValidAndInvalidSegments(carbonTable.isChildTable).getValidSegments.isEmpty) 
{
+        val allSegments = new 
SegmentStatusManager(carbonTable.getAbsoluteTableIdentifier)
+          .getValidAndInvalidSegments(carbonTable.isChildTable)
+        if (allSegments.getValidSegments.isEmpty) {
           sizeInBytesLocalValue = 0L
         } else {
           val tablePath = carbonTable.getTablePath
           val fileType = FileFactory.getFileType(tablePath)
           if (FileFactory.isFileExist(tablePath, fileType)) {
             // get the valid segments
-            val segments = new 
SegmentStatusManager(carbonTable.getAbsoluteTableIdentifier)
-              
.getValidAndInvalidSegments(carbonTable.isChildTable).getValidSegments.asScala
+            val segments = allSegments.getValidSegments.asScala
             var size = 0L
             // for each segment calculate the size
             segments.foreach { validSeg =>

Reply via email to