[carbondata] branch master updated: [CARBONDATA-4030] Fix getPositionId udf issue in concurrent SI global sort

[qiangcai]

This is an automated email from the ASF dual-hosted git repository.

qiangcai pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/carbondata.git


The following commit(s) were added to refs/heads/master by this push:
     new 18af657  [CARBONDATA-4030] Fix getPositionId udf issue in concurrent 
SI global sort
18af657 is described below

commit 18af65728492350d4a06f8f6465c4365ab9fcbe7
Author: ajantha-bhat <ajanthab...@gmail.com>
AuthorDate: Tue Sep 22 17:27:32 2020 +0530

    [CARBONDATA-4030] Fix getPositionId udf issue in concurrent SI global sort
    
    Why is this PR needed?
    when concurrent SI global sort is in progress, one load was removing the 
table property added by the other load. So, the global sort insert for one load 
was failing with error that unable to find position id in the projection.
    
    What changes were proposed in this PR?
    Keep the table properties for main table when SI global sort load is done. 
No need to remove it.
    Tested other scenarios on main table like compaction, insert and select.
    
    Does this PR introduce any user interface change?
    No
    
    Is any new testcase added?
    No [concurrent scenario]
    
    This closes #3949
---
 .../spark/sql/execution/strategy/CarbonLateDecodeStrategy.scala       | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git 
a/integration/spark/src/main/scala/org/apache/spark/sql/execution/strategy/CarbonLateDecodeStrategy.scala
 
b/integration/spark/src/main/scala/org/apache/spark/sql/execution/strategy/CarbonLateDecodeStrategy.scala
index a53cf50..415e19a 100644
--- 
a/integration/spark/src/main/scala/org/apache/spark/sql/execution/strategy/CarbonLateDecodeStrategy.scala
+++ 
b/integration/spark/src/main/scala/org/apache/spark/sql/execution/strategy/CarbonLateDecodeStrategy.scala
@@ -627,9 +627,7 @@ private[sql] class CarbonLateDecodeStrategy extends 
SparkStrategy {
           .getFactTable
           .getTableProperties
         val isPosIDRequested = if 
(tblProperties.containsKey("isPositionIDRequested")) {
-          val flag = 
java.lang.Boolean.parseBoolean(tblProperties.get("isPositionIDRequested"))
-          tblProperties.remove("isPositionIDRequested")
-          flag
+          
java.lang.Boolean.parseBoolean(tblProperties.get("isPositionIDRequested"))
         } else {
           false
         }