This is an automated email from the ASF dual-hosted git repository.
chenliang613 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/carbondata.git
The following commit(s) were added to refs/heads/master by this push:
new 8264b3be55 [ISSUE-4313] Add @Override for override method of
processing module (#4314)
8264b3be55 is described below
commit 8264b3be55e4d7af87e32878af53ccfdbf14b5a9
Author: Bo Xu <[email protected]>
AuthorDate: Sat Jul 8 21:07:49 2023 +0800
[ISSUE-4313] Add @Override for override method of processing module (#4314)
---
.../apache/carbondata/processing/exception/SliceMergerException.java | 1 +
.../apache/carbondata/processing/loading/csvinput/BlockDetails.java | 1 +
.../processing/loading/exception/BadRecordFoundException.java | 1 +
.../processing/loading/exception/CarbonDataLoadingException.java | 1 +
.../carbondata/processing/loading/exception/NoRetryException.java | 1 +
.../processing/loading/partition/impl/HashPartitionerImpl.java | 2 ++
.../loading/partition/impl/SparkHashExpressionPartitionerImpl.java | 4 ++++
.../loading/sort/unsafe/comparator/UnsafeRowComparator.java | 1 +
.../sort/unsafe/comparator/UnsafeRowComparatorForNormalDims.java | 1 +
.../loading/sort/unsafe/holder/UnsafeFinalMergePageHolder.java | 5 +++++
.../processing/loading/sort/unsafe/holder/UnsafeInmemoryHolder.java | 5 +++++
.../loading/sort/unsafe/holder/UnsafeSortTempFileChunkHolder.java | 4 ++++
.../sort/unsafe/merger/UnsafeSingleThreadFinalSortFilesMerger.java | 3 +++
.../carbondata/processing/merger/CompactionResultSortProcessor.java | 1 +
.../carbondata/processing/merger/RowResultMergerProcessor.java | 1 +
.../processing/sort/exception/CarbonSortKeyAndGroupByException.java | 1 +
.../processing/sort/sortdata/InMemorySortTempChunkHolder.java | 5 +++++
.../processing/sort/sortdata/IntermediateSortTempRowComparator.java | 1 +
.../apache/carbondata/processing/sort/sortdata/NewRowComparator.java | 1 +
.../processing/sort/sortdata/NewRowComparatorForNormalDims.java | 1 +
.../processing/sort/sortdata/SingleThreadFinalSortFilesMerger.java | 4 ++++
.../carbondata/processing/store/CarbonFactDataHandlerColumnar.java | 4 ++++
.../carbondata/processing/store/writer/AbstractFactDataWriter.java | 1 +
.../processing/store/writer/v3/CarbonFactDataWriterImplV3.java | 1 +
24 files changed, 51 insertions(+)
diff --git
a/processing/src/main/java/org/apache/carbondata/processing/exception/SliceMergerException.java
b/processing/src/main/java/org/apache/carbondata/processing/exception/SliceMergerException.java
index f9d1c1da5f..9fe9e1e556 100644
---
a/processing/src/main/java/org/apache/carbondata/processing/exception/SliceMergerException.java
+++
b/processing/src/main/java/org/apache/carbondata/processing/exception/SliceMergerException.java
@@ -50,6 +50,7 @@ public class SliceMergerException extends Exception {
/**
* getMessage
*/
+ @Override
public String getMessage() {
return this.msg;
}
diff --git
a/processing/src/main/java/org/apache/carbondata/processing/loading/csvinput/BlockDetails.java
b/processing/src/main/java/org/apache/carbondata/processing/loading/csvinput/BlockDetails.java
index 15cabcf390..6862e53a11 100644
---
a/processing/src/main/java/org/apache/carbondata/processing/loading/csvinput/BlockDetails.java
+++
b/processing/src/main/java/org/apache/carbondata/processing/loading/csvinput/BlockDetails.java
@@ -66,6 +66,7 @@ public class BlockDetails extends FileSplit implements
Serializable {
this.filePath = filePath;
}
+ @Override
public String[] getLocations() {
return locations;
}
diff --git
a/processing/src/main/java/org/apache/carbondata/processing/loading/exception/BadRecordFoundException.java
b/processing/src/main/java/org/apache/carbondata/processing/loading/exception/BadRecordFoundException.java
index c1c5a8f600..54b33b2273 100644
---
a/processing/src/main/java/org/apache/carbondata/processing/loading/exception/BadRecordFoundException.java
+++
b/processing/src/main/java/org/apache/carbondata/processing/loading/exception/BadRecordFoundException.java
@@ -51,6 +51,7 @@ public class BadRecordFoundException extends
CarbonDataLoadingException {
/**
* getMessage
*/
+ @Override
public String getMessage() {
return this.msg;
}
diff --git
a/processing/src/main/java/org/apache/carbondata/processing/loading/exception/CarbonDataLoadingException.java
b/processing/src/main/java/org/apache/carbondata/processing/loading/exception/CarbonDataLoadingException.java
index 13e75dfbbf..8bb1fad4d4 100644
---
a/processing/src/main/java/org/apache/carbondata/processing/loading/exception/CarbonDataLoadingException.java
+++
b/processing/src/main/java/org/apache/carbondata/processing/loading/exception/CarbonDataLoadingException.java
@@ -68,6 +68,7 @@ public class CarbonDataLoadingException extends
RuntimeException {
/**
* getMessage
*/
+ @Override
public String getMessage() {
return this.msg;
}
diff --git
a/processing/src/main/java/org/apache/carbondata/processing/loading/exception/NoRetryException.java
b/processing/src/main/java/org/apache/carbondata/processing/loading/exception/NoRetryException.java
index 41256a68cb..cc50146453 100644
---
a/processing/src/main/java/org/apache/carbondata/processing/loading/exception/NoRetryException.java
+++
b/processing/src/main/java/org/apache/carbondata/processing/loading/exception/NoRetryException.java
@@ -42,6 +42,7 @@ public class NoRetryException extends RuntimeException {
/**
* getMessage
*/
+ @Override
public String getMessage() {
return this.msg;
}
diff --git
a/processing/src/main/java/org/apache/carbondata/processing/loading/partition/impl/HashPartitionerImpl.java
b/processing/src/main/java/org/apache/carbondata/processing/loading/partition/impl/HashPartitionerImpl.java
index c9da2640ca..1817cd4cff 100644
---
a/processing/src/main/java/org/apache/carbondata/processing/loading/partition/impl/HashPartitionerImpl.java
+++
b/processing/src/main/java/org/apache/carbondata/processing/loading/partition/impl/HashPartitionerImpl.java
@@ -75,6 +75,7 @@ public class HashPartitionerImpl implements
Partitioner<CarbonRow> {
this.index = index;
}
+ @Override
public int getHash(Object[] value) {
return value[index] != null ?
Long.valueOf(value[index].toString()).hashCode() : 0;
}
@@ -88,6 +89,7 @@ public class HashPartitionerImpl implements
Partitioner<CarbonRow> {
this.index = index;
}
+ @Override
public int getHash(Object[] value) {
return value[index] != null ?
Double.valueOf(value[index].toString()).hashCode() : 0;
}
diff --git
a/processing/src/main/java/org/apache/carbondata/processing/loading/partition/impl/SparkHashExpressionPartitionerImpl.java
b/processing/src/main/java/org/apache/carbondata/processing/loading/partition/impl/SparkHashExpressionPartitionerImpl.java
index 92e1320872..bce461b483 100644
---
a/processing/src/main/java/org/apache/carbondata/processing/loading/partition/impl/SparkHashExpressionPartitionerImpl.java
+++
b/processing/src/main/java/org/apache/carbondata/processing/loading/partition/impl/SparkHashExpressionPartitionerImpl.java
@@ -88,6 +88,7 @@ public class SparkHashExpressionPartitionerImpl implements
Partitioner<CarbonRow
this.index = index;
}
+ @Override
public int getHash(Object[] value) {
if (value[index] == null) {
return 42;
@@ -113,6 +114,7 @@ public class SparkHashExpressionPartitionerImpl implements
Partitioner<CarbonRow
this.index = index;
}
+ @Override
public int getHash(Object[] value) {
if (value[index] == null) {
return 42;
@@ -135,6 +137,7 @@ public class SparkHashExpressionPartitionerImpl implements
Partitioner<CarbonRow
this.index = index;
}
+ @Override
public int getHash(Object[] value) {
if (value[index] == null) {
return 42;
@@ -153,6 +156,7 @@ public class SparkHashExpressionPartitionerImpl implements
Partitioner<CarbonRow
this.index = index;
}
+ @Override
public int getHash(Object[] value) {
if (value[index] == null) {
return 42;
diff --git
a/processing/src/main/java/org/apache/carbondata/processing/loading/sort/unsafe/comparator/UnsafeRowComparator.java
b/processing/src/main/java/org/apache/carbondata/processing/loading/sort/unsafe/comparator/UnsafeRowComparator.java
index b0109fa6d1..797d8e6345 100644
---
a/processing/src/main/java/org/apache/carbondata/processing/loading/sort/unsafe/comparator/UnsafeRowComparator.java
+++
b/processing/src/main/java/org/apache/carbondata/processing/loading/sort/unsafe/comparator/UnsafeRowComparator.java
@@ -43,6 +43,7 @@ public class UnsafeRowComparator implements
Comparator<UnsafeCarbonRow> {
/**
* Below method will be used to compare two mdkey
*/
+ @Override
public int compare(UnsafeCarbonRow rowL, UnsafeCarbonRow rowR) {
return compare(rowL, baseObject, rowR, baseObject);
}
diff --git
a/processing/src/main/java/org/apache/carbondata/processing/loading/sort/unsafe/comparator/UnsafeRowComparatorForNormalDims.java
b/processing/src/main/java/org/apache/carbondata/processing/loading/sort/unsafe/comparator/UnsafeRowComparatorForNormalDims.java
index e9cfb1c166..c06e7b681e 100644
---
a/processing/src/main/java/org/apache/carbondata/processing/loading/sort/unsafe/comparator/UnsafeRowComparatorForNormalDims.java
+++
b/processing/src/main/java/org/apache/carbondata/processing/loading/sort/unsafe/comparator/UnsafeRowComparatorForNormalDims.java
@@ -37,6 +37,7 @@ public class UnsafeRowComparatorForNormalDims implements
Comparator<UnsafeCarbon
/**
* Below method will be used to compare two mdkey
*/
+ @Override
public int compare(UnsafeCarbonRow rowL, UnsafeCarbonRow rowR) {
int diff = 0;
long rowA = rowL.address;
diff --git
a/processing/src/main/java/org/apache/carbondata/processing/loading/sort/unsafe/holder/UnsafeFinalMergePageHolder.java
b/processing/src/main/java/org/apache/carbondata/processing/loading/sort/unsafe/holder/UnsafeFinalMergePageHolder.java
index 7abd3a9f6d..8c7a9b8085 100644
---
a/processing/src/main/java/org/apache/carbondata/processing/loading/sort/unsafe/holder/UnsafeFinalMergePageHolder.java
+++
b/processing/src/main/java/org/apache/carbondata/processing/loading/sort/unsafe/holder/UnsafeFinalMergePageHolder.java
@@ -67,6 +67,7 @@ public class UnsafeFinalMergePageHolder implements
SortTempChunkHolder {
tableFieldStat.getDictSortColIdxSchemaOrderMapping());
}
+ @Override
public boolean hasNext() {
if (counter < actualSize) {
return true;
@@ -74,11 +75,13 @@ public class UnsafeFinalMergePageHolder implements
SortTempChunkHolder {
return false;
}
+ @Override
public void readRow() {
currentRow =
rowPages[rowPageIndexes[counter]].getRow(mergedAddresses[counter]);
counter++;
}
+ @Override
public IntermediateSortTempRow getRow() {
return currentRow;
}
@@ -107,10 +110,12 @@ public class UnsafeFinalMergePageHolder implements
SortTempChunkHolder {
return super.hashCode();
}
+ @Override
public int numberOfRows() {
return actualSize;
}
+ @Override
public void close() {
for (int i = 0; i < rowPages.length; i++) {
rowPages[i].freeMemory();
diff --git
a/processing/src/main/java/org/apache/carbondata/processing/loading/sort/unsafe/holder/UnsafeInmemoryHolder.java
b/processing/src/main/java/org/apache/carbondata/processing/loading/sort/unsafe/holder/UnsafeInmemoryHolder.java
index a21e8024c1..685577d252 100644
---
a/processing/src/main/java/org/apache/carbondata/processing/loading/sort/unsafe/holder/UnsafeInmemoryHolder.java
+++
b/processing/src/main/java/org/apache/carbondata/processing/loading/sort/unsafe/holder/UnsafeInmemoryHolder.java
@@ -55,6 +55,7 @@ public class UnsafeInmemoryHolder implements
SortTempChunkHolder {
this.rowPage.setReadConvertedNoSortField();
}
+ @Override
public boolean hasNext() {
if (counter < actualSize) {
return true;
@@ -62,12 +63,14 @@ public class UnsafeInmemoryHolder implements
SortTempChunkHolder {
return false;
}
+ @Override
public void readRow() {
address = rowPage.getBuffer().get(counter);
currentRow = rowPage.getRow(address +
rowPage.getDataBlock().getBaseOffset());
counter++;
}
+ @Override
public IntermediateSortTempRow getRow() {
return currentRow;
}
@@ -97,10 +100,12 @@ public class UnsafeInmemoryHolder implements
SortTempChunkHolder {
return super.hashCode();
}
+ @Override
public int numberOfRows() {
return actualSize;
}
+ @Override
public void close() {
rowPage.freeMemory();
}
diff --git
a/processing/src/main/java/org/apache/carbondata/processing/loading/sort/unsafe/holder/UnsafeSortTempFileChunkHolder.java
b/processing/src/main/java/org/apache/carbondata/processing/loading/sort/unsafe/holder/UnsafeSortTempFileChunkHolder.java
index 77b19f4de7..174cb95004 100644
---
a/processing/src/main/java/org/apache/carbondata/processing/loading/sort/unsafe/holder/UnsafeSortTempFileChunkHolder.java
+++
b/processing/src/main/java/org/apache/carbondata/processing/loading/sort/unsafe/holder/UnsafeSortTempFileChunkHolder.java
@@ -254,6 +254,7 @@ public class UnsafeSortTempFileChunkHolder implements
SortTempChunkHolder {
*
* @return row
*/
+ @Override
public IntermediateSortTempRow getRow() {
return this.returnRow;
}
@@ -264,6 +265,7 @@ public class UnsafeSortTempFileChunkHolder implements
SortTempChunkHolder {
*
* @return more row present in file
*/
+ @Override
public boolean hasNext() {
if (prefetch) {
return this.prefetchRecordsProceesed < this.entryCount;
@@ -274,6 +276,7 @@ public class UnsafeSortTempFileChunkHolder implements
SortTempChunkHolder {
/**
* Below method will be used to close streams
*/
+ @Override
public void close() {
CarbonUtil.closeStreams(stream);
if (null != executorService && !executorService.isShutdown()) {
@@ -286,6 +289,7 @@ public class UnsafeSortTempFileChunkHolder implements
SortTempChunkHolder {
*
* @return entryCount
*/
+ @Override
public int numberOfRows() {
return entryCount;
}
diff --git
a/processing/src/main/java/org/apache/carbondata/processing/loading/sort/unsafe/merger/UnsafeSingleThreadFinalSortFilesMerger.java
b/processing/src/main/java/org/apache/carbondata/processing/loading/sort/unsafe/merger/UnsafeSingleThreadFinalSortFilesMerger.java
index 6d8df392aa..059888ee94 100644
---
a/processing/src/main/java/org/apache/carbondata/processing/loading/sort/unsafe/merger/UnsafeSingleThreadFinalSortFilesMerger.java
+++
b/processing/src/main/java/org/apache/carbondata/processing/loading/sort/unsafe/merger/UnsafeSingleThreadFinalSortFilesMerger.java
@@ -164,6 +164,7 @@ public class UnsafeSingleThreadFinalSortFilesMerger extends
CarbonIterator<Objec
final int rangeId = parameters.getRangeId();
FileFilter fileFilter = new FileFilter() {
+ @Override
public boolean accept(File pathname) {
return pathname.getName().startsWith(tableName + '_' + rangeId);
}
@@ -196,6 +197,7 @@ public class UnsafeSingleThreadFinalSortFilesMerger extends
CarbonIterator<Objec
*
* @return sorted row
*/
+ @Override
public Object[] next() {
if (hasNext()) {
return
sortStepRowHandler.convertIntermediateSortTempRowTo3Parted(getSortedRecordFromFile());
@@ -255,6 +257,7 @@ public class UnsafeSingleThreadFinalSortFilesMerger extends
CarbonIterator<Objec
*
* @return more element is present
*/
+ @Override
public boolean hasNext() {
return this.fileCounter > 0;
}
diff --git
a/processing/src/main/java/org/apache/carbondata/processing/merger/CompactionResultSortProcessor.java
b/processing/src/main/java/org/apache/carbondata/processing/merger/CompactionResultSortProcessor.java
index 98670994c0..a6b178ddaa 100644
---
a/processing/src/main/java/org/apache/carbondata/processing/merger/CompactionResultSortProcessor.java
+++
b/processing/src/main/java/org/apache/carbondata/processing/merger/CompactionResultSortProcessor.java
@@ -170,6 +170,7 @@ public class CompactionResultSortProcessor extends
AbstractResultProcessor {
* @return if the compaction is success or not
* @throws Exception
*/
+ @Override
public boolean execute(List<RawResultIterator> unsortedResultIteratorList,
List<RawResultIterator> sortedResultIteratorList) throws Exception {
boolean isCompactionSuccess = false;
diff --git
a/processing/src/main/java/org/apache/carbondata/processing/merger/RowResultMergerProcessor.java
b/processing/src/main/java/org/apache/carbondata/processing/merger/RowResultMergerProcessor.java
index 64643060dd..aa7ca50e6c 100644
---
a/processing/src/main/java/org/apache/carbondata/processing/merger/RowResultMergerProcessor.java
+++
b/processing/src/main/java/org/apache/carbondata/processing/merger/RowResultMergerProcessor.java
@@ -105,6 +105,7 @@ public class RowResultMergerProcessor extends
AbstractResultProcessor {
* Merge function
*
*/
+ @Override
public boolean execute(List<RawResultIterator> unsortedResultIteratorList,
List<RawResultIterator> sortedResultIteratorList) throws Exception {
List<RawResultIterator> finalIteratorList = new
ArrayList<>(unsortedResultIteratorList);
diff --git
a/processing/src/main/java/org/apache/carbondata/processing/sort/exception/CarbonSortKeyAndGroupByException.java
b/processing/src/main/java/org/apache/carbondata/processing/sort/exception/CarbonSortKeyAndGroupByException.java
index e5783b9ac1..d55105381c 100644
---
a/processing/src/main/java/org/apache/carbondata/processing/sort/exception/CarbonSortKeyAndGroupByException.java
+++
b/processing/src/main/java/org/apache/carbondata/processing/sort/exception/CarbonSortKeyAndGroupByException.java
@@ -82,6 +82,7 @@ public class CarbonSortKeyAndGroupByException extends
Exception {
/**
* getMessage
*/
+ @Override
public String getMessage() {
return this.msg;
}
diff --git
a/processing/src/main/java/org/apache/carbondata/processing/sort/sortdata/InMemorySortTempChunkHolder.java
b/processing/src/main/java/org/apache/carbondata/processing/sort/sortdata/InMemorySortTempChunkHolder.java
index 4d41fc0917..af19e492a7 100644
---
a/processing/src/main/java/org/apache/carbondata/processing/sort/sortdata/InMemorySortTempChunkHolder.java
+++
b/processing/src/main/java/org/apache/carbondata/processing/sort/sortdata/InMemorySortTempChunkHolder.java
@@ -73,6 +73,7 @@ public class InMemorySortTempChunkHolder extends
SortTempFileChunkHolder {
* 2. Convert it to IntermediateSortTempRow
* 3. Store it in memory to read through getRow() method
*/
+ @Override
public void readRow() {
Object[] row = this.rawResultIterator.next();
//TODO add code to get directly Object[] Instead Of CarbonRow Object
@@ -88,6 +89,7 @@ public class InMemorySortTempChunkHolder extends
SortTempFileChunkHolder {
}
+ @Override
public int getEntryCount() {
// this will not be used for intermediate sorting
throw new UnsupportedOperationException("Operation Not supported");
@@ -99,6 +101,7 @@ public class InMemorySortTempChunkHolder extends
SortTempFileChunkHolder {
*
* @return more row present in file
*/
+ @Override
public boolean hasNext() {
return this.rawResultIterator.hasNext();
}
@@ -118,6 +121,7 @@ public class InMemorySortTempChunkHolder extends
SortTempFileChunkHolder {
/**
* Below method will be used to close streams
*/
+ @Override
public void closeStream() {
rawResultIterator.close();
}
@@ -126,6 +130,7 @@ public class InMemorySortTempChunkHolder extends
SortTempFileChunkHolder {
*
* @return row
*/
+ @Override
public IntermediateSortTempRow getRow() {
return returnRow;
}
diff --git
a/processing/src/main/java/org/apache/carbondata/processing/sort/sortdata/IntermediateSortTempRowComparator.java
b/processing/src/main/java/org/apache/carbondata/processing/sort/sortdata/IntermediateSortTempRowComparator.java
index 62d541fce1..d4ce2e82b0 100644
---
a/processing/src/main/java/org/apache/carbondata/processing/sort/sortdata/IntermediateSortTempRowComparator.java
+++
b/processing/src/main/java/org/apache/carbondata/processing/sort/sortdata/IntermediateSortTempRowComparator.java
@@ -48,6 +48,7 @@ public class IntermediateSortTempRowComparator implements
Comparator<Intermediat
/**
* Below method will be used to compare two sort temp row
*/
+ @Override
public int compare(IntermediateSortTempRow rowA, IntermediateSortTempRow
rowB) {
int diff = 0;
int dictIndex = 0;
diff --git
a/processing/src/main/java/org/apache/carbondata/processing/sort/sortdata/NewRowComparator.java
b/processing/src/main/java/org/apache/carbondata/processing/sort/sortdata/NewRowComparator.java
index 09b3a59ac4..89360871f9 100644
---
a/processing/src/main/java/org/apache/carbondata/processing/sort/sortdata/NewRowComparator.java
+++
b/processing/src/main/java/org/apache/carbondata/processing/sort/sortdata/NewRowComparator.java
@@ -41,6 +41,7 @@ public class NewRowComparator implements
Comparator<Object[]>, Serializable {
/**
* Below method will be used to compare two mdkey
*/
+ @Override
public int compare(Object[] rowA, Object[] rowB) {
int diff = 0;
int index = 0;
diff --git
a/processing/src/main/java/org/apache/carbondata/processing/sort/sortdata/NewRowComparatorForNormalDims.java
b/processing/src/main/java/org/apache/carbondata/processing/sort/sortdata/NewRowComparatorForNormalDims.java
index 69ed2fd131..6f3f381b36 100644
---
a/processing/src/main/java/org/apache/carbondata/processing/sort/sortdata/NewRowComparatorForNormalDims.java
+++
b/processing/src/main/java/org/apache/carbondata/processing/sort/sortdata/NewRowComparatorForNormalDims.java
@@ -46,6 +46,7 @@ public class NewRowComparatorForNormalDims implements
Comparator<Object[]>, Seri
*
* @see Comparator#compare(Object, Object)
*/
+ @Override
public int compare(Object[] rowA, Object[] rowB) {
int diff = 0;
diff --git
a/processing/src/main/java/org/apache/carbondata/processing/sort/sortdata/SingleThreadFinalSortFilesMerger.java
b/processing/src/main/java/org/apache/carbondata/processing/sort/sortdata/SingleThreadFinalSortFilesMerger.java
index c3f45b1c63..42a742fdd6 100644
---
a/processing/src/main/java/org/apache/carbondata/processing/sort/sortdata/SingleThreadFinalSortFilesMerger.java
+++
b/processing/src/main/java/org/apache/carbondata/processing/sort/sortdata/SingleThreadFinalSortFilesMerger.java
@@ -140,6 +140,7 @@ public class SingleThreadFinalSortFilesMerger extends
CarbonIterator<Object[]> {
private List<File> getFilesToMergeSort() {
final int rangeId = sortParameters.getRangeId();
FileFilter fileFilter = new FileFilter() {
+ @Override
public boolean accept(File pathname) {
return pathname.getName().startsWith(tableName + '_' + rangeId);
}
@@ -246,6 +247,7 @@ public class SingleThreadFinalSortFilesMerger extends
CarbonIterator<Object[]> {
* @return sorted row
* @throws CarbonSortKeyAndGroupByException
*/
+ @Override
public Object[] next() {
if (hasNext()) {
IntermediateSortTempRow sortTempRow = getSortedRecordFromFile();
@@ -305,10 +307,12 @@ public class SingleThreadFinalSortFilesMerger extends
CarbonIterator<Object[]> {
*
* @return more element is present
*/
+ @Override
public boolean hasNext() {
return this.recordHolderHeapLocal != null &&
this.recordHolderHeapLocal.size() > 0;
}
+ @Override
public void close() {
if (null != executorService && !executorService.isShutdown()) {
executorService.shutdownNow();
diff --git
a/processing/src/main/java/org/apache/carbondata/processing/store/CarbonFactDataHandlerColumnar.java
b/processing/src/main/java/org/apache/carbondata/processing/store/CarbonFactDataHandlerColumnar.java
index cc056ee76c..85ba51b908 100644
---
a/processing/src/main/java/org/apache/carbondata/processing/store/CarbonFactDataHandlerColumnar.java
+++
b/processing/src/main/java/org/apache/carbondata/processing/store/CarbonFactDataHandlerColumnar.java
@@ -206,6 +206,7 @@ public class CarbonFactDataHandlerColumnar implements
CarbonFactHandler {
*
* @throws CarbonDataWriterException
*/
+ @Override
public void initialise() throws CarbonDataWriterException {
setWritingConfiguration();
}
@@ -216,6 +217,7 @@ public class CarbonFactDataHandlerColumnar implements
CarbonFactHandler {
* @param row
* @throws CarbonDataWriterException
*/
+ @Override
public void addDataToStore(CarbonRow row) throws CarbonDataWriterException {
int totalComplexColumnDepth = setFlatCarbonRowForComplex(row);
if (noDictColumnPageSize == null) {
@@ -410,6 +412,7 @@ public class CarbonFactDataHandlerColumnar implements
CarbonFactHandler {
*
* @throws CarbonDataWriterException
*/
+ @Override
public void finish() throws CarbonDataWriterException {
// still some data is present in stores if entryCount is more
// than 0
@@ -480,6 +483,7 @@ public class CarbonFactDataHandlerColumnar implements
CarbonFactHandler {
/**
* below method will be used to close the handler
*/
+ @Override
public void closeHandler() throws CarbonDataWriterException {
if (null != this.dataWriter) {
// wait until all blocklets have been finished writing
diff --git
a/processing/src/main/java/org/apache/carbondata/processing/store/writer/AbstractFactDataWriter.java
b/processing/src/main/java/org/apache/carbondata/processing/store/writer/AbstractFactDataWriter.java
index 57bf63d965..088062b5e5 100644
---
a/processing/src/main/java/org/apache/carbondata/processing/store/writer/AbstractFactDataWriter.java
+++
b/processing/src/main/java/org/apache/carbondata/processing/store/writer/AbstractFactDataWriter.java
@@ -324,6 +324,7 @@ public abstract class AbstractFactDataWriter implements
CarbonFactDataWriter {
*
* @throws CarbonDataWriterException
*/
+ @Override
public void initializeWriter() throws CarbonDataWriterException {
this.carbonDataFileName = CarbonTablePath
.getCarbonDataFileName(fileCount,
model.getCarbonDataFileAttributes().getTaskId(),
diff --git
a/processing/src/main/java/org/apache/carbondata/processing/store/writer/v3/CarbonFactDataWriterImplV3.java
b/processing/src/main/java/org/apache/carbondata/processing/store/writer/v3/CarbonFactDataWriterImplV3.java
index dad1f0b5c1..4bc027a790 100644
---
a/processing/src/main/java/org/apache/carbondata/processing/store/writer/v3/CarbonFactDataWriterImplV3.java
+++
b/processing/src/main/java/org/apache/carbondata/processing/store/writer/v3/CarbonFactDataWriterImplV3.java
@@ -381,6 +381,7 @@ public class CarbonFactDataWriterImplV3 extends
AbstractFactDataWriter {
*
* @throws CarbonDataWriterException
*/
+ @Override
public void closeWriter() throws CarbonDataWriterException {
CarbonDataWriterException exception = null;
try {
