[carbondata] branch master updated: optmize code smell in presto module (#4331)

[chenliang613]

This is an automated email from the ASF dual-hosted git repository.

chenliang613 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/carbondata.git


The following commit(s) were added to refs/heads/master by this push:
     new 46188086c0 optmize code smell in presto module (#4331)
46188086c0 is described below

commit 46188086c0c289554cd8ccbc3249f43f84633b2d
Author: Bo Xu <601450...@qq.com>
AuthorDate: Wed Oct 18 04:51:52 2023 +0800

    optmize code smell in presto module (#4331)
    
    add override
---
 .../java/org/apache/carbondata/presto/ColumnarVectorWrapperDirect.java | 3 +++
 .../prestodb/org/apache/carbondata/presto/impl/CarbonTableReader.java  | 1 +
 .../org/apache/carbondata/presto/readers/ComplexTypeStreamReader.java  | 1 +
 .../prestosql/org/apache/carbondata/presto/impl/CarbonTableReader.java | 1 +
 .../org/apache/carbondata/presto/readers/ComplexTypeStreamReader.java  | 1 +
 5 files changed, 7 insertions(+)

diff --git 
a/integration/presto/src/main/java/org/apache/carbondata/presto/ColumnarVectorWrapperDirect.java
 
b/integration/presto/src/main/java/org/apache/carbondata/presto/ColumnarVectorWrapperDirect.java
index caf38203be..8e641e9f1f 100644
--- 
a/integration/presto/src/main/java/org/apache/carbondata/presto/ColumnarVectorWrapperDirect.java
+++ 
b/integration/presto/src/main/java/org/apache/carbondata/presto/ColumnarVectorWrapperDirect.java
@@ -207,14 +207,17 @@ public class ColumnarVectorWrapperDirect implements 
CarbonColumnVector, Sequenti
     columnVector.putObject(rowId, obj);
   }
 
+  @Override
   public CarbonColumnVectorImpl getColumnVector() {
     return this.columnVector;
   }
 
+  @Override
   public List<CarbonColumnVector> getChildrenVector() {
     return columnVector.getChildrenVector();
   }
 
+  @Override
   public void putComplexObject(List<Integer> offsetVector) {
     columnVector.putComplexObject(offsetVector);
   }
diff --git 
a/integration/presto/src/main/prestodb/org/apache/carbondata/presto/impl/CarbonTableReader.java
 
b/integration/presto/src/main/prestodb/org/apache/carbondata/presto/impl/CarbonTableReader.java
index 9e833ecbfd..ed3d8603f6 100755
--- 
a/integration/presto/src/main/prestodb/org/apache/carbondata/presto/impl/CarbonTableReader.java
+++ 
b/integration/presto/src/main/prestodb/org/apache/carbondata/presto/impl/CarbonTableReader.java
@@ -203,6 +203,7 @@ public class CarbonTableReader {
             // TableInfo is a kind of TBase used to read and write table 
information.
             // TableInfo is generated by thrift,
             // see schema.thrift under format/src/main/thrift for details.
+            @Override
             public TBase create() {
               return new org.apache.carbondata.format.TableInfo();
             }
diff --git 
a/integration/presto/src/main/prestodb/org/apache/carbondata/presto/readers/ComplexTypeStreamReader.java
 
b/integration/presto/src/main/prestodb/org/apache/carbondata/presto/readers/ComplexTypeStreamReader.java
index e3dbbb6cf3..3a172ccdd5 100644
--- 
a/integration/presto/src/main/prestodb/org/apache/carbondata/presto/readers/ComplexTypeStreamReader.java
+++ 
b/integration/presto/src/main/prestodb/org/apache/carbondata/presto/readers/ComplexTypeStreamReader.java
@@ -112,6 +112,7 @@ public class ComplexTypeStreamReader extends 
CarbonColumnVectorImpl
     this.batchSize = batchSize;
   }
 
+  @Override
   public void putComplexObject(List<Integer> offsetVector) {
     if (type instanceof ArrayType) {
       // build child block
diff --git 
a/integration/presto/src/main/prestosql/org/apache/carbondata/presto/impl/CarbonTableReader.java
 
b/integration/presto/src/main/prestosql/org/apache/carbondata/presto/impl/CarbonTableReader.java
index 19464068a9..63ea471bb3 100755
--- 
a/integration/presto/src/main/prestosql/org/apache/carbondata/presto/impl/CarbonTableReader.java
+++ 
b/integration/presto/src/main/prestosql/org/apache/carbondata/presto/impl/CarbonTableReader.java
@@ -198,6 +198,7 @@ public class CarbonTableReader {
             // TableInfo is a kind of TBase used to read and write table 
information.
             // TableInfo is generated by thrift,
             // see schema.thrift under format/src/main/thrift for details.
+            @Override
             public TBase create() {
               return new org.apache.carbondata.format.TableInfo();
             }
diff --git 
a/integration/presto/src/main/prestosql/org/apache/carbondata/presto/readers/ComplexTypeStreamReader.java
 
b/integration/presto/src/main/prestosql/org/apache/carbondata/presto/readers/ComplexTypeStreamReader.java
index d0f66c4986..b574744818 100644
--- 
a/integration/presto/src/main/prestosql/org/apache/carbondata/presto/readers/ComplexTypeStreamReader.java
+++ 
b/integration/presto/src/main/prestosql/org/apache/carbondata/presto/readers/ComplexTypeStreamReader.java
@@ -112,6 +112,7 @@ public class ComplexTypeStreamReader extends 
CarbonColumnVectorImpl
     this.batchSize = batchSize;
   }
 
+  @Override
   public void putComplexObject(List<Integer> offsetVector) {
     if (type instanceof ArrayType) {
       // build child block