Re: [PR] fix: update CDN asset links to relative paths in index.js [casbin-website]

[via GitHub]

Copilot commented on code in PR #454:
URL: https://github.com/apache/casbin-website/pull/454#discussion_r2982059281


##########
src/components/LanguageIntegration/index.js:
##########
@@ -5,89 +5,89 @@ import styles from "./styles.module.css";
 const languages = [
   {
     name: "Golang",
-    icon: "https://cdn.casbin.org/language/go-logo-1.svg";,
+    icon: "/img/langs/go-logo-1.svg",
     url: "https://github.com/casbin";,
   },
   {
     name: "Java",
-    icon: "https://cdn.casbin.org/language/jee-3.svg";,
+    icon: "/img/langs/jee-3.svg",
     url: "https://github.com/casbin/jcasbin";,
   },
   {
     name: "C/C++",
-    icon: "https://cdn.casbin.org/language/c.svg";,
+    icon: "/img/langs/c.svg",
     url: "https://github.com/casbin/casbin-cpp";,
   },
   {
     name: "Node.js",
-    icon: "https://cdn.casbin.org/language/nodejs-1.svg";,
+    icon: "/img/langs/nodejs-1.svg",
     url: "https://github.com/casbin/node-casbin";,
   },
   {
     name: "Front-end JavaScript",
-    icon: "https://cdn.casbin.org/language/logo-javascript.svg";,
+    icon: "/img/langs/logo-javascript.svg",
     url: "https://github.com/casbin/casbin.js";,
   },
   {
     name: "PHP",
-    icon: "https://cdn.casbin.org/language/PHP-logo.svg";,
+    icon: "/img/langs/PHP-logo.svg",
     url: "https://github.com/php-casbin/php-casbin";,
   },
   {
     name: "Laravel",
-    icon: "https://cdn.casbin.org/language/laravel-2.svg";,
+    icon: "/img/langs/laravel-2.svg",
     url: "https://github.com/php-casbin/laravel-authz";,
   },
   {
     name: "Python",
-    icon: "https://cdn.casbin.org/language/python-5.svg";,
+    icon: "/img/langs/python-5.svg",
     url: "https://github.com/casbin/pycasbin";,
   },
   {
     name: ".NET (C#)",
-    icon: "https://cdn.casbin.org/language/dotnet-logo.svg";,
+    icon: "/img/langs/dotnet-logo.svg",
     url: "https://github.com/casbin/Casbin.NET";,
   },
   {
     name: "Delphi",
-    icon: "https://cdn.casbin.org/language/delphi-2.svg";,
+    icon: "/img/langs/delphi-2.svg",
     url: "https://github.com/casbin4d/Casbin4D";,
   },
   {
     name: "Rust",
-    icon: "https://cdn.casbin.org/language/rust.svg";,
+    icon: "/img/langs/rust.svg",
     url: "https://github.com/casbin/casbin-rs";,
   },
   {
     name: "Ruby",
-    icon: "https://cdn.casbin.org/language/ruby.svg";,
+    icon: "/img/langs/ruby.svg",
     url: "https://github.com/CasbinRuby/casbin-ruby";,
   },
   {
     name: "Swift (Objective-C)",
-    icon: "https://cdn.casbin.org/language/swift-15.svg";,
+    icon: "/img/langs/swift-15.svg",
     url: "https://github.com/casbin/SwiftCasbin";,
   },
   {
     name: "Lua (OpenResty, Kong, APISIX)",
-    icon: "https://cdn.casbin.org/language/lua-5.svg";,
+    icon: "/img/langs/lua-5.svg",
     url: "https://github.com/casbin/lua-casbin";,
   },
   {
     name: "Dart (Flutter)",
-    icon: "https://cdn.casbin.org/language/dart.svg";,
+    icon: "/img/langs/dart.svg",
     url: "https://github.com/casbin/dart-casbin";,
   },
   {
     name: "Elixir",
-    icon: "https://cdn.casbin.org/language/elixir-lang-icon.svg";,
+    icon: "/img/langs/elixir-lang-icon.svg",
     url: "https://github.com/casbin/casbin-ex";,
   },
   {
     name: "Cloud Native",
     displayName: "Cloud Native",
     fullName: "Cloud Native (Kubernetes, Istio, Envoy, KubeSphere)",
-    icon: "https://cdn.casbin.org/language/kubernets.svg";,
+    icon: "/img/langs/kubernets.svg",

Review Comment:
   The icon filename `kubernets.svg` appears to be a misspelling of 
`kubernetes.svg`. Consider renaming the asset and updating references so the 
codebase doesn’t permanently encode the typo.
   ```suggestion
       icon: "/img/langs/kubernetes.svg",
   ```



##########
src/utils/languageIconMapping.ts:
##########
@@ -3,36 +3,36 @@
  * Icons are sourced from the LanguageIntegration component
  */
 export const languageIconMapping: Record<string, string> = {
-  "Go": "https://cdn.casbin.org/language/go-logo-1.svg";,
-  "Golang": "https://cdn.casbin.org/language/go-logo-1.svg";,
-  "Java": "https://cdn.casbin.org/language/jee-3.svg";,
-  "C": "https://cdn.casbin.org/language/c.svg";,
-  "C++": "https://cdn.casbin.org/language/c.svg";,
-  "C/C++": "https://cdn.casbin.org/language/c.svg";,
-  "Node.js": "https://cdn.casbin.org/language/nodejs-1.svg";,
-  "Node": "https://cdn.casbin.org/language/nodejs-1.svg";,
-  "JavaScript": "https://cdn.casbin.org/language/logo-javascript.svg";,
-  "Front-end JavaScript": 
"https://cdn.casbin.org/language/logo-javascript.svg";,
-  "PHP": "https://cdn.casbin.org/language/PHP-logo.svg";,
-  "Laravel": "https://cdn.casbin.org/language/laravel-2.svg";,
-  "Python": "https://cdn.casbin.org/language/python-5.svg";,
-  ".NET": "https://cdn.casbin.org/language/dotnet-logo.svg";,
-  ".NET (C#)": "https://cdn.casbin.org/language/dotnet-logo.svg";,
-  "C#": "https://cdn.casbin.org/language/dotnet-logo.svg";,
-  "Delphi": "https://cdn.casbin.org/language/delphi-2.svg";,
-  "Rust": "https://cdn.casbin.org/language/rust.svg";,
-  "Ruby": "https://cdn.casbin.org/language/ruby.svg";,
-  "Swift": "https://cdn.casbin.org/language/swift-15.svg";,
-  "Swift (Objective-C)": "https://cdn.casbin.org/language/swift-15.svg";,
-  "Objective-C": "https://cdn.casbin.org/language/swift-15.svg";,
-  "Lua": "https://cdn.casbin.org/language/lua-5.svg";,
-  "Lua (OpenResty, Kong, APISIX)": "https://cdn.casbin.org/language/lua-5.svg";,
-  "Dart": "https://cdn.casbin.org/language/dart.svg";,
-  "Dart (Flutter)": "https://cdn.casbin.org/language/dart.svg";,
-  "Flutter": "https://cdn.casbin.org/language/dart.svg";,
-  "Elixir": "https://cdn.casbin.org/language/elixir-lang-icon.svg";,
-  "Cloud Native": "https://cdn.casbin.org/language/kubernets.svg";,
-  "Kubernetes": "https://cdn.casbin.org/language/kubernets.svg";,
+  "Go": "/img/langs/go-logo-1.svg",
+  "Golang": "/img/langs/go-logo-1.svg",
+  "Java": "/img/langs/jee-3.svg",
+  "C": "/img/langs/c.svg",
+  "C++": "/img/langs/c.svg",
+  "C/C++": "/img/langs/c.svg",
+  "Node.js": "/img/langs/nodejs-1.svg",
+  "Node": "/img/langs/nodejs-1.svg",
+  "JavaScript": "/img/langs/logo-javascript.svg",
+  "Front-end JavaScript": "/img/langs/logo-javascript.svg",
+  "PHP": "/img/langs/PHP-logo.svg",
+  "Laravel": "/img/langs/laravel-2.svg",
+  "Python": "/img/langs/python-5.svg",
+  ".NET": "/img/langs/dotnet-logo.svg",
+  ".NET (C#)": "/img/langs/dotnet-logo.svg",
+  "C#": "/img/langs/dotnet-logo.svg",
+  "Delphi": "/img/langs/delphi-2.svg",
+  "Rust": "/img/langs/rust.svg",
+  "Ruby": "/img/langs/ruby.svg",
+  "Swift": "/img/langs/swift-15.svg",
+  "Swift (Objective-C)": "/img/langs/swift-15.svg",
+  "Objective-C": "/img/langs/swift-15.svg",
+  "Lua": "/img/langs/lua-5.svg",
+  "Lua (OpenResty, Kong, APISIX)": "/img/langs/lua-5.svg",
+  "Dart": "/img/langs/dart.svg",
+  "Dart (Flutter)": "/img/langs/dart.svg",
+  "Flutter": "/img/langs/dart.svg",
+  "Elixir": "/img/langs/elixir-lang-icon.svg",
+  "Cloud Native": "/img/langs/kubernets.svg",
+  "Kubernetes": "/img/langs/kubernets.svg",

Review Comment:
   `/img/langs/kubernets.svg` looks like a misspelling. Consider renaming the 
asset to `kubernetes.svg` and updating this mapping to keep naming consistent 
and discoverable.
   ```suggestion
     "Cloud Native": "/img/langs/kubernetes.svg",
     "Kubernetes": "/img/langs/kubernetes.svg",
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@casbin.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@casbin.apache.org
For additional commands, e-mail: commits-h...@casbin.apache.org