dajiaohuang opened a new pull request, #573: URL: https://github.com/apache/casbin-node-casbin/pull/573
Util.array2DEquals reads a.length for both operands. As a result, an empty left array compares equal to a nonempty right array, and a matching prefix can hide trailing rows. Read b.length for the second operand. Add a regression covering both operand orders, trailing rows and empty rows, with a positive equality control. The new test fails on the original code (expected false, received true). Validation: lint passes with the yarn.lock Prettier 2.2.1 version; all 18 Jest suites / 240 tests pass with CASBIN_CONFORMANCE_DIR set to task-local upstream fixtures; coverage and both CJS/ESM builds pass. AI assistance: OpenAI Codex CLI 0.163.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
