[ 
https://issues.apache.org/jira/browse/CASSANDRA-714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859528#action_12859528
 ] 

Eric Evans commented on CASSANDRA-714:
--------------------------------------

A couple of things:

I might be missing something, but o.a.c.hadoop.ColumnFamilyRecordReader doesn't 
seem right. The instance of Cassandra.Client that is created in 
ColumnFamilyRecordReader.login() doesn't survive past the scope of that method. 
Won't the other Thrift calls fail?

Also, it appears that the access level check was removed from 
CassandraServer.system_add_keyspace().

I've still got some more testing to do in conjunction with CASSANDRA-859; I'll 
update the ticket if I find anything else.


> remove keyspace argument from thrift methods
> --------------------------------------------
>
>                 Key: CASSANDRA-714
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-714
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.6
>            Reporter: Eric Evans
>            Assignee: Todd Blose
>             Fix For: 0.7
>
>         Attachments: 
> 0001-CASSANDRA-714.-rm-keyspace-argument-from-thrift-meth.patch, 
> CASSANDRA-714.patch, CASSANDRA-714.patch.new, 
> CASSANDRA-714_python_tests.patch, CASSANDRA-714_server.patch, 
> CASSANDRA-714_thrift_def.patch
>
>
> With the completion of CASSANDRA-547, the keyspace can be specified as part 
> of the login and stored in a thread-local. This will allow us to remove the 
> wasteful and redundant mandatory keyspace argument on all of the other rpc 
> methods.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to