[
https://issues.apache.org/jira/browse/CASSANDRA-531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12863513#action_12863513
]
Jonathan Ellis edited comment on CASSANDRA-531 at 5/3/10 5:05 PM:
------------------------------------------------------------------
Patch applies cleanly now.
Sorry to throw this back again, but can you submit a patch that doesn't mess
with whitespace on otherwise-unedited lines?
(cleaning up whitespace in a separate patch is good, but mixing it in with
"real" changes pollutes the patch.)
also, if you can conform to http://wiki.apache.org/cassandra/CodeStyle even
where it's idiosyncratic, it helps keep the code base uniform. in particular,
argument alignment, use of public final fields, and throwing RuntimeException
instead of logging an error in catch statements.
Thanks!
was (Author: jbellis):
Sorry, can you submit a patch that doesn't mess with whitespace on
otherwise-unedited lines?
(cleaning up whitespace in a separate patch is good, but mixing it in with
"real" changes pollutes the patch.)
also, if you can conform to http://wiki.apache.org/cassandra/CodeStyle even
where it's idiosyncratic, it helps keep the code base uniform. in particular,
argument alignment, use of public final fields, and throwing RuntimeException
instead of logging an error in catch statements.
Thanks!
> truncate support
> ----------------
>
> Key: CASSANDRA-531
> URL: https://issues.apache.org/jira/browse/CASSANDRA-531
> Project: Cassandra
> Issue Type: New Feature
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Ran Tavory
> Priority: Minor
> Fix For: 0.7
>
> Attachments: 0001-CASSANDRA-531-add-truncate-truncateBefore.txt,
> 0002-add-unimplemented-truncate-to-thrift-API.txt, CASSANDRA-531.patch,
> CASSANDRA-531.patch, CASSANDRA-531.patch, CASSANDRA-531.patch,
> CASSANDRA-531.patch, CASSANDRA-531.patch, CASSANDRA-531.patch,
> CASSANDRA-531.patch
>
>
> Sometimes you want to delete an entire columnfamily. If there is a lot of
> data, it's much faster to just insert something to the commitlog saying
> "truncated," and drop the memtable and data files.
> Probably should require this to block for all replicas to ack to avoid
> unpleasant surprises. Or make it local-only and have ops manage making sure
> it gets to all replicas.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
