[
https://issues.apache.org/jira/browse/CASSANDRA-1070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12869119#action_12869119
]
Johan Oskarsson commented on CASSANDRA-1070:
--------------------------------------------
Had a quick look at the patch, overall it looks good. Couple of minor points:
cassandra.thrift still has a few references to timestamp instead of clock.
Would also be good to add some more user friendly documentation to the Clock
struct.
Only the cassandra.avpr file is changed, the genavro is not. I don't if we use
the genavro file though, can Eric Evans enlighten us?
A class level javadoc would be good for the ClockType and TimestampClock
classes, explaining what they are for. Esp in the timestamp one it might help
users when trying to pick the correct type of clock to use.
The TimestampClock compareTo unnecessarily creates two Long objects.
In FBUtilities it would be good to have some javadoc for atomicSetMax. I'm not
a big fan of the "goto" in there either, but perhaps that's just me.
> Update interface to use a wrapper for various clock types
> ---------------------------------------------------------
>
> Key: CASSANDRA-1070
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1070
> Project: Cassandra
> Issue Type: Sub-task
> Components: Core
> Reporter: Johan Oskarsson
> Assignee: Sylvain Lebresne
> Fix For: 0.7
>
> Attachments:
> 0001-Introduces-wrapper-for-clock-types-generalizing-time.patch,
> 0002-Update-unit-tests.patch, 0003-Update-System-tests.patch
>
>
> In the latest CASSANDRA-580 patch the timestamp used for conflict resolution
> has been replaced by a Clock object that can contain either timestamp or a
> context byte array. That change allows for other conflict resolution
> techniques to be used.
> The change can be broken out and submitted here in order to make
> CASSANDRA-580 more manageable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
