[ 
https://issues.apache.org/jira/browse/CASSANDRA-1204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12880915#action_12880915
 ] 

Eric Evans commented on CASSANDRA-1204:
---------------------------------------

First off, there are lots of whitespace issues (mixed tabs and spaces), and 
instances of incorrect brace placement. See http://wiki.apache.org/CodyStyle.

Also, I'm not a fan of the syntax used for keyspace and column family creation 
here. Could we try something like: {{create (keyspace|column family) name with 
attr=value [and attr=value [and...]]}}? I'm also not a fan of the renames, how 
about something like: {{rename (keyspace|column family) <src> <dst>}}?

All of these new commands should be setup to work with command completion.

And finally, authentication is kind of a mess in that it operates under the 
assumption that priviliges are tied to a keyspace. I think that (for now 
anyway), I'd prefer to see {{system_drop_keyspace()}} operate the same way that 
{{system_add_keyspace()}} does (namely that it is rejected outright when 
authentication is enabled).

> CliClient Support for add, drop, and rename should be added for keyspace and 
> column family
> ------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-1204
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1204
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Tools
>    Affects Versions: 0.7
>            Reporter: Mason Bryant
>            Priority: Minor
>             Fix For: 0.7
>
>         Attachments: cli_new_methods2.diff
>
>
> Should add support for the add, drop, and rename operations to keyspace and 
> column family in the CliClient.
> Eg:
> add keyspace <keyspace>                                      Add a new 
> keyspace.
> add column family <cf>[comparator]                      Add a new column 
> family.
> drop keyspace <keyspace>                                      Delete a 
> keyspace.
> drop column family <cf>                                  Delete a column 
> family.
> rename keyspace <keyspace>=<keyspace_new_name>                Rename a 
> keyspace.
> rename column family <name>=<new_name>                   Rename a column 
> family.
> Note: I have patch built for this, but drop keyspace corrupts the schema and 
> prevents the node from restarting due to a bug elsewhere (see: CASSANDRA-1203)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to