[
https://issues.apache.org/jira/browse/CASSANDRA-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stu Hood updated CASSANDRA-1471:
--------------------------------
Attachment: 0005-Clean-up-callers-who-were-abusing-the-Filename-metho.patch
> how about if we continue to return descriptor, and let the caller ask for
> Descriptor.componentFor(Component.Type) if necessary?
'componentFromFilename' is for callers who need to know the component identity
of a file: since the set of components isn't necessarily fixed anymore, they
may not know to ask for a particular component, without being handed it.
'fromFilename' still returns the sstable identity of a file, but you're right:
there were a few (indirect) callers to clean up. Both SSTableDeletingReference
and CFS.snapshot still had bugs: fixed in 0005. The remaining callers for
fromFilename look justified (enough) to leave in (for now).
> Improve SSTable discovery and allow for more components
> -------------------------------------------------------
>
> Key: CASSANDRA-1471
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1471
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Stu Hood
> Assignee: Stu Hood
> Fix For: 0.7.0
>
> Attachments:
> 0001-Prepare-to-have-a-fifth-type-of-SSTable-file-by-addi.patch,
> 0002-Incorporate-Components-into-ColumnFamilyStore-loadin.patch,
> 0003-Remove-extraneous-SSTR-constructor-and-factory-funct.patch,
> 0004-Incorporate-Components-into-SSTable-load-process.patch,
> 0005-Clean-up-callers-who-were-abusing-the-Filename-metho.patch
>
>
> A new 'Statistics.db' component was added recently, and it is likely that
> more components will follow. Due to our parsing code using a regex to detect
> 'orphan' files (rather than a checked type) a bug slipped through that
> prevents the new component from being detected as an orphan.
> To continue to be able to scale the components of SSTables, we should
> formalize 'Components'.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
