[ 
https://issues.apache.org/jira/browse/CASSANDRA-1425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12907073#action_12907073
 ] 

Jeremy Hanna commented on CASSANDRA-1425:
-----------------------------------------

There is still an issue with CFMetaData from CASSANDRA-891 - convertToThrift 
now defaults values like subcomparator_type to empty string instead of null.  
So in ColumnFamilyRecordReader, it checks for null for that, but needs to take 
into account empty string.  From a discussion in IRC, Jonathan said it would 
probably be easier to make it default to null again.  Will be a separate ticket.

> get input splits thrift method still takes a KS as an arg
> ---------------------------------------------------------
>
>                 Key: CASSANDRA-1425
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1425
>             Project: Cassandra
>          Issue Type: Task
>          Components: Core
>    Affects Versions: 0.7 beta 1
>            Reporter: Jeremy Hanna
>            Assignee: Jeremy Hanna
>            Priority: Minor
>             Fix For: 0.7 beta 2
>
>         Attachments: 0001-1425-non-api-changes.patch, 
> 0002-1425-api-changes.patch
>
>
> the get input splits method still takes a keyspace as an arg.  it shouldn't 
> need to and iirc, there should be a keySpace var in that class so that method 
> could just use keySpace.getString().  I just didn't have a chance to test it 
> out and I didn't want it to slip through the cracks.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to